Bug 126933

Summary:

Update WebPageProxyIOS's user agent string

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Benjamin Poulain

Reported 2014-01-13 14:50:06 PST

Update WebPageProxyIOS's user agent string

Attachments
Patch (1.83 KB, patch) 2014-01-13 14:51 PST, Benjamin Poulain	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-01-13 14:51:08 PST

Darin Adler

Comment 2 2014-01-13 16:50:06 PST

Comment on attachment 221080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221080&action=review > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51 > + return (NSString *)overrideUserAgent; I think you can remove that typecast.

Benjamin Poulain

Comment 3 2014-01-13 19:39:21 PST

(In reply to comment #2) > (From update of attachment 221080 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221080&action=review > > > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:51 > > + return (NSString *)overrideUserAgent; > > I think you can remove that typecast. Good catch.

Benjamin Poulain

Comment 4 2014-01-13 19:48:51 PST

Note You need to log in before you can comment on or make changes to this bug.