Bug 126925

Summary:

[WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebGL

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, roger_fong, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

126963, 126992

Bug Blocks:

Attachments:

Description	Flags
Patch	dino: review+

Brent Fulgham

Reported 2014-01-13 12:21:16 PST

The existing logic for texture level checking in WebGLRenderingContext::validateTexFuncLevel had an off-by-one error. It ensured that we never exceeded the value of "m_maxTextureLevel" (or "m_maxCubeMapTextureLevel"). However, these values mark the upper bound of the texture level; the storage is sized to hold this count of entries, but the actual levels are 0-indexed.

Attachments
Patch (66.53 KB, patch) 2014-01-13 13:49 PST, Brent Fulgham	dino: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2014-01-13 13:49:54 PST

Created attachment 221078 [details] Patch

Brent Fulgham

Comment 2 2014-01-13 14:23:12 PST

Committed r161907: <http://trac.webkit.org/changeset/161907>

Alexey Proskuryakov

Comment 3 2014-01-13 21:44:25 PST

fast/canvas/webgl/webgl-compressed-texture-size-limit.html fails on all Mountain Lion bots, and is flaky on Mavericks. Brent, are you available to look into this now?

WebKit Commit Bot

Comment 4 2014-01-13 21:56:33 PST

Re-opened since this is blocked by bug 126963

Alexey Proskuryakov

Comment 5 2014-01-13 22:01:17 PST

Rolling out, bots are noisy tonight. Some diffs: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r161909%20(12225)/fast/canvas/webgl/webgl-compressed-texture-size-limit-pretty-diff.html http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r161931%20(1608)/fast/canvas/webgl/webgl-compressed-texture-size-limit-pretty-diff.html

Brent Fulgham

Comment 6 2014-01-13 23:58:45 PST

(In reply to comment #3) > fast/canvas/webgl/webgl-compressed-texture-size-limit.html fails on all Mountain Lion bots, and is flaky on Mavericks. > > Brent, are you available to look into this now? Crap. It's graphics-card specific.

Brent Fulgham

Comment 7 2014-01-14 09:48:47 PST

Revising tests to limit texture memory to 8196, to match our smallest test bots.

Brent Fulgham

Comment 8 2014-01-14 09:49:10 PST

Committed r161978: <http://trac.webkit.org/changeset/161978>

Alexey Proskuryakov

Comment 9 2014-01-14 10:24:08 PST

This test is now crashing on bots (at least some, most haven't caught up yet): http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r161978%20(2387)/fast/canvas/webgl/webgl-compressed-texture-size-limit-crash-log.txt

WebKit Commit Bot

Comment 10 2014-01-14 10:31:58 PST

Re-opened since this is blocked by bug 126992