Bug 126917 – Map RootInlineBox to containing region via bit+hashmap.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Andreas Kling]

Map RootInlineBox to containing region via bit+hashmap.

[Andreas Kling]

Created attachment 221062 [details]
Patch

[Antti Koivisto]

Comment on attachment 221062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221062&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:279
>  void RootInlineBox::setContainingRegion(RenderRegion* region)
>  {
>      ASSERT(!isDirty());
>      ASSERT(blockFlow().flowThreadContainingBlock());
> -    m_containingRegion = region;
> +
> +    if (!region && !m_hasContainingRegion)
> +        return;
> +
> +    if (region)
> +        containingRegionMap().set(this, region);
> +    else
> +        containingRegionMap().remove(this);
> +
> +    m_hasContainingRegion = !!region;
>  }

It would be nicer to have setContainingRegion(RenderRegion&) and clearContainingRegion() separately.

[Andreas Kling]

Created attachment 221067 [details]
Moon lander

[WebKit Commit Bot]

Comment on attachment 221067 [details]
Moon lander

Clearing flags on attachment: 221067

Committed r161909: <http://trac.webkit.org/changeset/161909>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.