Bug 126901

Summary:

Performance regression on dromaeo due to generational marking

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Hahnenberg 2014-01-13 07:49:49 PST

Generational marking is off in ToT, but some of the machinery to make it work isn't fully disabled which is causing regressions on dromaeo. We should disable more things to get to a point where the patch is no regression when ENABLE_GGC == 0 because it would be nice to have the option to disable generational collection for diagnosing any potential GGC bugs.

Comment 1 Mark Hahnenberg 2014-01-13 12:58:26 PST

Created attachment 221075 [details]
Patch

Comment 2 Mark Hahnenberg 2014-01-13 15:11:52 PST

I ran dromaeo and it looks like this patch fixes the obvious regressions.

Comment 3 WebKit Commit Bot 2014-01-13 15:46:51 PST

Comment on attachment 221075 [details]
Patch

Clearing flags on attachment: 221075

Committed r161914: <http://trac.webkit.org/changeset/161914>

Comment 4 WebKit Commit Bot 2014-01-13 15:46:52 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Joseph Pecoraro 2015-10-06 18:21:09 PDT

*** Bug 126902 has been marked as a duplicate of this bug. ***