Bug 126882

Summary: [EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2014-01-13 04:27:25 PST
SSIA.
Attachments
Patch (6.34 KB, patch)
2014-01-13 04:29 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (6.33 KB, patch)
2014-01-13 07:04 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-01-13 04:29:01 PST
Created attachment 221028 [details] Patch
Sergio Correia (qrwteyrutiyoup)
Comment 2 2014-01-13 04:32:26 PST
Comment on attachment 221028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221028&action=review > Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:66 > + static NeverDestroyed<String> webKitWebProcessName(findProcessPath(WEBPROCESSNAME)); NeverDestroyed<const String> here? > Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:73 > + static NeverDestroyed<String> webKitPluginProcessName(findProcessPath(PLUGINPROCESSNAME)); Ditto. > Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:81 > + static NeverDestroyed<String> webKitNetworkProcessName(findProcessPath(NETWORKPROCESSNAME)); Ditto.
Jinwoo Song
Comment 3 2014-01-13 07:04:53 PST
Created attachment 221038 [details] Patch
Jinwoo Song
Comment 4 2014-01-13 07:05:24 PST
Comment on attachment 221028 [details] Patch done!
WebKit Commit Bot
Comment 5 2014-01-13 15:58:47 PST
Comment on attachment 221038 [details] Patch Clearing flags on attachment: 221038 Committed r161915: <http://trac.webkit.org/changeset/161915>
WebKit Commit Bot
Comment 6 2014-01-13 15:58:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.