Bug 126881

Summary:

[GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cgarcia, commit-queue, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Adrian Perez 2014-01-13 02:57:19 PST

[GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser

Comment 1 Adrian Perez 2014-01-13 02:59:44 PST

Created attachment 221021 [details]
Patch

Comment 2 Carlos Garcia Campos 2014-01-13 03:04:47 PST

Comment on attachment 221021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221021&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:710
> -        g_object_add_weak_pointer(G_OBJECT(parent), &window->parentWindow);
> +        g_object_add_weak_pointer(G_OBJECT(parent), (gpointer*) &window->parentWindow);

Add a space between the gpointer and the * and remove the space between the parentheses and the &

g_object_add_weak_pointer(G_OBJECT(parent), (gpointer *)&window->parentWindow);

Comment 3 Adrian Perez 2014-01-13 03:11:36 PST

Created attachment 221023 [details]
Patch

Comment 4 WebKit Commit Bot 2014-01-13 03:46:51 PST

Comment on attachment 221023 [details]
Patch

Clearing flags on attachment: 221023

Committed r161875: <http://trac.webkit.org/changeset/161875>

Comment 5 WebKit Commit Bot 2014-01-13 03:46:52 PST

All reviewed patches have been landed.  Closing bug.