Bug 126881

Summary: [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
Product: WebKit Reporter: Adrian Perez <aperez>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adrian Perez
Reported 2014-01-13 02:57:19 PST
[GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
Attachments
Patch (1.40 KB, patch)
2014-01-13 02:59 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2014-01-13 03:11 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2014-01-13 02:59:44 PST
Created attachment 221021 [details] Patch
Carlos Garcia Campos
Comment 2 2014-01-13 03:04:47 PST
Comment on attachment 221021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221021&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:710 > - g_object_add_weak_pointer(G_OBJECT(parent), &window->parentWindow); > + g_object_add_weak_pointer(G_OBJECT(parent), (gpointer*) &window->parentWindow); Add a space between the gpointer and the * and remove the space between the parentheses and the & g_object_add_weak_pointer(G_OBJECT(parent), (gpointer *)&window->parentWindow);
Adrian Perez
Comment 3 2014-01-13 03:11:36 PST
Created attachment 221023 [details] Patch
WebKit Commit Bot
Comment 4 2014-01-13 03:46:51 PST
Comment on attachment 221023 [details] Patch Clearing flags on attachment: 221023 Committed r161875: <http://trac.webkit.org/changeset/161875>
WebKit Commit Bot
Comment 5 2014-01-13 03:46:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.