Bug 126873

Summary: REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, cdumez, cgarcia, changseok, commit-queue, dbates, ddkilzer, mtiborinf, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2014-01-13 00:19:34 PST
WebKit bindings tests complain about uninitialized PLATFORM_NAME a lot, see e.g. <https://webkit-queues.appspot.com/results/6110151471792128>: Running bindings generation tests Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63. PASS: (JS) JSTestCallback.cpp PASS: (JS) JSTestCallback.h Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63. PASS: (JS) JSTestCustomNamedGetter.cpp PASS: (JS) JSTestCustomNamedGetter.h Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63. PASS: (JS) JSTestActiveDOMObject.cpp PASS: (JS) JSTestActiveDOMObject.h Use of uninitialized value $ENV{"PLATFORM_NAME"} in pattern match (m//) at WebCore/bindings/scripts/preprocessor.pm line 63.
Attachments
Patch (2.33 KB, patch)
2014-01-13 07:29 PST, Tibor Mészáros 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tibor Mészáros
Comment 1 2014-01-13 07:29:32 PST
Created attachment 221039 [details] Patch Now checked that the $ENV{"PLATFORM_NAME"} is defined or not.
WebKit Commit Bot
Comment 2 2014-01-13 08:11:39 PST
Comment on attachment 221039 [details] Patch Clearing flags on attachment: 221039 Committed r161878: <http://trac.webkit.org/changeset/161878>
WebKit Commit Bot
Comment 3 2014-01-13 08:11:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.