| Summary: | Fix build warnings by unused parameter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||
| Component: | WebKit Misc. | Assignee: | Jinwoo Song <jinwoo7.song> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, bunhere, cdumez, commit-queue, gyuyoung.kim, jsbell, rakuco | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 221001 [details]
Patch
Comment on attachment 221001 [details]
Patch
In this case, I think variable type isn't primitive. Thus, we're able to know the meaning of removing parameters after this patch. Looks fine.
Comment on attachment 221001 [details] Patch Clearing flags on attachment: 221001 Committed r161860: <http://trac.webkit.org/changeset/161860> All reviewed patches have been landed. Closing bug. |
In file included from /home/jinwoo/opensource/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:37:0: /home/jinwoo/opensource/WebKit/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h:151:40: warning: unused parameter ‘checkingTypes’ [-Wunused-parameter] virtual Vector<TextCheckingResult> checkTextOfParagraph(StringView, TextCheckingTypeMask checkingTypes) { return Vector<TextCheckingResult>(); } /home/jinwoo/opensource/WebKit/Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:558:6: warning: unused parameter ‘operation’ [-Wunused-parameter] void IDBServerConnectionLevelDB::changeDatabaseVersion(IDBTransactionBackend& transaction, const IDBDatabaseBackend::VersionChangeOperation& operation, std::function<void(PassRefPtr<IDBDatabaseError>)> completionCallback)