Bug 126867

Summary: Fix build warnings by unused parameter
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, bunhere, cdumez, commit-queue, gyuyoung.kim, jsbell, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jinwoo Song
Reported 2014-01-12 19:46:56 PST
In file included from /home/jinwoo/opensource/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:37:0: /home/jinwoo/opensource/WebKit/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h:151:40: warning: unused parameter ‘checkingTypes’ [-Wunused-parameter] virtual Vector<TextCheckingResult> checkTextOfParagraph(StringView, TextCheckingTypeMask checkingTypes) { return Vector<TextCheckingResult>(); } /home/jinwoo/opensource/WebKit/Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:558:6: warning: unused parameter ‘operation’ [-Wunused-parameter] void IDBServerConnectionLevelDB::changeDatabaseVersion(IDBTransactionBackend& transaction, const IDBDatabaseBackend::VersionChangeOperation& operation, std::function<void(PassRefPtr<IDBDatabaseError>)> completionCallback)
Attachments
Patch (3.43 KB, patch)
2014-01-12 20:49 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-01-12 20:49:31 PST
Created attachment 221001 [details] Patch
Gyuyoung Kim
Comment 2 2014-01-12 21:43:23 PST
Comment on attachment 221001 [details] Patch In this case, I think variable type isn't primitive. Thus, we're able to know the meaning of removing parameters after this patch. Looks fine.
WebKit Commit Bot
Comment 3 2014-01-12 22:14:08 PST
Comment on attachment 221001 [details] Patch Clearing flags on attachment: 221001 Committed r161860: <http://trac.webkit.org/changeset/161860>
WebKit Commit Bot
Comment 4 2014-01-12 22:14:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.