| Summary: | Remove all uses of AtomicallyInitializedStatic from WebCore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, commit-queue, jsbell | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2014-01-12 17:53:18 PST
Created attachment 220993 [details]
Patch
Comment on attachment 220993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220993&action=review > Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:47 > + transactions = new ThreadSpecific<TransactionList>(); No need for the "()" here. > Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:84 > + map = new ThreadSpecific<BlobUrlOriginMap>(); Ditto. Attachment 220993 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp', u'Source/WebCore/fileapi/ThreadableBlobRegistry.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/workers/DefaultSharedWorkerRepository.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:46: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:83: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/workers/DefaultSharedWorkerRepository.cpp:346: Missing space before { [whitespace/braces] [5]
Total errors found: 3 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r161847: <http://trac.webkit.org/changeset/161847> |