Bug 126833

Summary:

Web Inspector: Resource and Frame saveIdentityToCookie should store URL hashes not URLs

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2014-01-11 20:35:27 PST

To save space and avoid some privacy leaks in URLs getting saved to disk, we should use String.prototype.hash to save the identity of the URL without the actual URL.

We use String.prototype.hash for many state WebInspector.Settings already, some for URLs.

Comment 1 Radar WebKit Bug Importer 2014-01-11 20:35:38 PST

<rdar://problem/15800369>

Comment 2 Diego Pino 2014-03-14 05:05:01 PDT

Created attachment 226688 [details]
Patch

Comment 3 Timothy Hatcher 2014-03-14 08:35:04 PDT

Comment on attachment 226688 [details]
Patch

Thanks!

Comment 4 WebKit Commit Bot 2014-03-14 09:07:00 PDT

Comment on attachment 226688 [details]
Patch

Clearing flags on attachment: 226688

Committed r165621: <http://trac.webkit.org/changeset/165621>

Comment 5 WebKit Commit Bot 2014-03-14 09:07:03 PDT

All reviewed patches have been landed.  Closing bug.