Bug 126833 - Web Inspector: Resource and Frame saveIdentityToCookie should store URL hashes not URLs
Summary: Web Inspector: Resource and Frame saveIdentityToCookie should store URL hashe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-11 20:35 PST by Timothy Hatcher
Modified: 2014-03-14 09:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.18 KB, patch)
2014-03-14 05:05 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-11 20:35:27 PST
To save space and avoid some privacy leaks in URLs getting saved to disk, we should use String.prototype.hash to save the identity of the URL without the actual URL.

We use String.prototype.hash for many state WebInspector.Settings already, some for URLs.
Comment 1 Radar WebKit Bug Importer 2014-01-11 20:35:38 PST
<rdar://problem/15800369>
Comment 2 Diego Pino 2014-03-14 05:05:01 PDT
Created attachment 226688 [details]
Patch
Comment 3 Timothy Hatcher 2014-03-14 08:35:04 PDT
Comment on attachment 226688 [details]
Patch

Thanks!
Comment 4 WebKit Commit Bot 2014-03-14 09:07:00 PDT
Comment on attachment 226688 [details]
Patch

Clearing flags on attachment: 226688

Committed r165621: <http://trac.webkit.org/changeset/165621>
Comment 5 WebKit Commit Bot 2014-03-14 09:07:03 PDT
All reviewed patches have been landed.  Closing bug.