Bug 126831

Summary: Web Inspector: Implement bar graph rendering for OverviewTimelineView
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+, timothy: commit-queue-
Screenshot none

Timothy Hatcher
Reported 2014-01-11 19:51:31 PST
The rendering for resources and source code timelines needs implemented.
Attachments
Patch (39.38 KB, patch)
2014-01-11 20:06 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Screenshot (694.67 KB, image/png)
2014-01-11 20:09 PST, Timothy Hatcher 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-11 19:51:42 PST
<rdar://problem/15800345>
Timothy Hatcher
Comment 2 2014-01-11 20:06:23 PST
Created attachment 220952 [details] Patch
Timothy Hatcher
Comment 3 2014-01-11 20:09:39 PST
Created attachment 220953 [details] Screenshot
Joseph Pecoraro
Comment 4 2014-01-17 11:48:17 PST
Comment on attachment 220952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220952&action=review r=me > Source/WebInspectorUI/UserInterface/TimelineDataGridNode.js:98 > + } else { > + timelineRecordBar.element.remove(); > + } Style: Braces not needed. > Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:86 > + // If this bar is completly after the current time, return early. Typo: completly > Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:90 > + // If this bar is completly before or after the bounds of the graph, return early. Typo: completly
Timothy Hatcher
Comment 5 2014-01-20 19:03:33 PST
https://trac.webkit.org/changeset/162412
Note You need to log in before you can comment on or make changes to this bug.