Bug 126831

Summary:

Web Inspector: Implement bar graph rendering for OverviewTimelineView

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, timothy: commit-queue-
Screenshot	none

Description Timothy Hatcher 2014-01-11 19:51:31 PST

The rendering for resources and source code timelines needs implemented.

Comment 1 Radar WebKit Bug Importer 2014-01-11 19:51:42 PST

<rdar://problem/15800345>

Comment 2 Timothy Hatcher 2014-01-11 20:06:23 PST

Created attachment 220952 [details]
Patch

Comment 3 Timothy Hatcher 2014-01-11 20:09:39 PST

Created attachment 220953 [details]
Screenshot

Comment 4 Joseph Pecoraro 2014-01-17 11:48:17 PST

Comment on attachment 220952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220952&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineDataGridNode.js:98
> +            } else {
> +                timelineRecordBar.element.remove();
> +            }

Style: Braces not needed.

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:86
> +        // If this bar is completly after the current time, return early.

Typo: completly

> Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:90
> +        // If this bar is completly before or after the bounds of the graph, return early.

Typo: completly

Comment 5 Timothy Hatcher 2014-01-20 19:03:33 PST

https://trac.webkit.org/changeset/162412