Bug 126828

Summary: Web Inspector: protocol generator should support integer-typed declarations
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, graouts, gyuyoung.kim, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
New generated type builder - includes typedef BreakpointActionIdentifier none

Description BJ Burg 2014-01-11 18:40:42 PST 
If you edit Runtime.json, the inspector code generator does not re-run (or at least, the files that ScriptDebugServer/etc in WebCore sees are stale).
Comment 1 Radar WebKit Bug Importer 2014-01-11 18:40:59 PST 
<rdar://problem/15800306>
Comment 2 BJ Burg 2014-01-11 19:15:30 PST 
Disregard the previous comment; it seems the code generator was simply ignoring an added type, make it appear to be stale.
Comment 3 BJ Burg 2014-01-11 21:01:51 PST 
Created attachment 220954 [details]
patch
Comment 4 EFL EWS Bot 2014-01-12 05:16:43 PST 
Comment on attachment 220954 [details]
patch

Attachment 220954 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/4554984884535296
Comment 5 BJ Burg 2014-01-12 14:08:50 PST 
The EFL failure is an unrelated ICE on Document.cpp
Comment 6 BJ Burg 2014-01-12 15:19:22 PST 
Created attachment 220986 [details]
New generated type builder - includes typedef BreakpointActionIdentifier
Comment 7 Joseph Pecoraro 2014-01-13 10:49:48 PST 
Comment on attachment 220954 [details]
patch

r=me
Comment 8 BJ Burg 2014-01-13 12:06:11 PST 
Comment on attachment 220954 [details]
patch

Clearing flags on attachment: 220954

Committed r161900: <http://trac.webkit.org/changeset/161900>
Comment 9 BJ Burg 2014-01-13 12:06:14 PST 
All reviewed patches have been landed.  Closing bug.