Bug 126828

Summary: Web Inspector: protocol generator should support integer-typed declarations
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, graouts, gyuyoung.kim, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
New generated type builder - includes typedef BreakpointActionIdentifier none

Blaze Burg
Reported 2014-01-11 18:40:42 PST
If you edit Runtime.json, the inspector code generator does not re-run (or at least, the files that ScriptDebugServer/etc in WebCore sees are stale).
Attachments
patch (7.46 KB, patch)
2014-01-11 21:01 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
New generated type builder - includes typedef BreakpointActionIdentifier (47.44 KB, text/plain)
2014-01-12 15:19 PST, Blaze Burg 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-11 18:40:59 PST
<rdar://problem/15800306>
Blaze Burg
Comment 2 2014-01-11 19:15:30 PST
Disregard the previous comment; it seems the code generator was simply ignoring an added type, make it appear to be stale.
Blaze Burg
Comment 3 2014-01-11 21:01:51 PST
Created attachment 220954 [details] patch
EFL EWS Bot
Comment 4 2014-01-12 05:16:43 PST
Comment on attachment 220954 [details] patch Attachment 220954 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4554984884535296
Blaze Burg
Comment 5 2014-01-12 14:08:50 PST
The EFL failure is an unrelated ICE on Document.cpp
Blaze Burg
Comment 6 2014-01-12 15:19:22 PST
Created attachment 220986 [details] New generated type builder - includes typedef BreakpointActionIdentifier
Joseph Pecoraro
Comment 7 2014-01-13 10:49:48 PST
Comment on attachment 220954 [details] patch r=me
Blaze Burg
Comment 8 2014-01-13 12:06:11 PST
Comment on attachment 220954 [details] patch Clearing flags on attachment: 220954 Committed r161900: <http://trac.webkit.org/changeset/161900>
Blaze Burg
Comment 9 2014-01-13 12:06:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.