Bug 126792

Summary: Fix CharsetData.cpp build for iOS
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrowe: review+

Description Simon Fraser (smfr) 2014-01-10 16:29:29 PST
Fix CharsetData.cpp build for iOS
Comment 1 Simon Fraser (smfr) 2014-01-10 16:31:17 PST
Created attachment 220905 [details]
Patch
Comment 2 Mark Rowe (bdash) 2014-01-10 16:34:51 PST
Comment on attachment 220905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220905&action=review

r=me

> Source/WebCore/DerivedSources.make:1194
> +ifeq ($(WTF_PLATFORM_IOS),1)
> +
> +CharsetData.cpp : platform/text/mac/make-charset-table.pl platform/text/mac/character-sets.txt platform/text/mac/ios-encodings.txt
> +	perl $^ kTextEncoding > $@
> +
> +else
> +
>  CharsetData.cpp : platform/text/mac/make-charset-table.pl platform/text/mac/character-sets.txt platform/text/mac/mac-encodings.txt
>  	perl $^ kTextEncoding > $@
>  
> +endif # WTF_PLATFORM_IOS

Can we avoid some of the duplication by pulling the path to the encodings file in to a variable instead?
Comment 3 Simon Fraser (smfr) 2014-01-10 16:54:33 PST
http://trac.webkit.org/changeset/161698