|Summary:||Web Inspector: Remove unimplemented or static ScriptDebugServer features|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Component:||Web Inspector||Assignee:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||commit-queue, graouts, joepeck, timothy, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description Joseph Pecoraro 2014-01-10 14:43:16 PST
In our inspector frontend these methods are all unused and in the backend they are unimplemented. Lets remove them. These functions were needed for the following features / reasons: • differences between v8 and JSC • detecting if features were available or not "canFoo*" • live script editing • snippet support • script preprocessor, a script that can analyze any Script evaluated in the JS engine We can implement these ourselves if/when we decide to add such features. Right now all of this code is stale / unimplemented.
Comment 1 Joseph Pecoraro 2014-01-10 14:47:01 PST
Created attachment 220891 [details] [PATCH] Proposed Fix Note that I leave iOS 7's PageAgent.reload with the optional scriptPreprocessor parameter. Unlike other times where we retroactively delete whole commands from Legacy Inspector.json files, this is not deleting a whole command, and so I think we should be be explicit about what the backend expected from that method.
Comment 3 WebKit Commit Bot 2014-01-10 15:52:13 PST
Comment on attachment 220891 [details] [PATCH] Proposed Fix Clearing flags on attachment: 220891 Committed r161691: <http://trac.webkit.org/changeset/161691>
Comment 4 WebKit Commit Bot 2014-01-10 15:52:15 PST
All reviewed patches have been landed. Closing bug.