Bug 126769 – [EFL][WK2] Make API tests work again

• Component: New Bugs
• Status: RESOLVED FIXED

[Sergio Correia (qrwteyrutiyoup)]

[EFL][WK2] Make API tests work again

[Sergio Correia (qrwteyrutiyoup)]

The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
[E]WebKit2, respectively, and this causes problems because the logic to find
where WebProcess is to look in the same directory of the running process and
then proceed to use LIBEXECDIR (typically /usr/loca/bin).

This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
Gtk port, which allows us to look for WebProcess initially in this directory,
if it's defined.

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 220870 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 220870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220870&action=review

Looks make sense. Please land after fixing my comments.

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:44
> +        executablePath = WebCore::pathByAppendingComponent(String(execDirectory), processName);

String(execDirectory) -> String::fromUTF8(execDirectory) ?

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:59
> +        executablePath = WebCore::pathByAppendingComponent(String(executablePathPtr), processName);

ditto ?

> Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp:66
> +        LOG_ERROR("Failed to locate the path of '%s'.", processName);

Don't you need to return nullptr ?

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 220994 [details]
v2 with Gyuyoung remakrs

[Gyuyoung Kim]

Comment on attachment 220994 [details]
v2 with Gyuyoung remakrs

LGTM.

[Gyuyoung Kim]

If you already got r+, then, you don't need to get r+ again.

[WebKit Commit Bot]

Comment on attachment 220994 [details]
v2 with Gyuyoung remakrs

Clearing flags on attachment: 220994

Committed r161857: <http://trac.webkit.org/changeset/161857>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.