Summary: | Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bunhere, commit-queue, eflews.bot, ggaren, graouts, gtk-ews, gyuyoung.kim, joepeck, mark.lam, rakuco, rego+ews, timothy, webkit-bug-importer, xan.lopez, zan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-01-10 10:54:51 PST
Adding JSC engineers because the patch will make use of APIShims. Created attachment 220869 [details]
[PATCH] Proposed Fix
Attachment 220869 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.cpp', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgent.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/inspector/CommandLineAPIHost.cpp', u'Source/WebCore/inspector/CommandLineAPIHost.h', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InstrumentingAgents.h', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageConsoleAgent.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 5 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220869 [details] [PATCH] Proposed Fix Attachment 220869 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6413797338120192 Comment on attachment 220869 [details] [PATCH] Proposed Fix Attachment 220869 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/6209058797256704 Created attachment 220873 [details]
[PATCH] Proposed Fix
Comment on attachment 220873 [details] [PATCH] Proposed Fix Attachment 220873 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6026769245143040 Comment on attachment 220873 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=220873&action=review Nice and clean. > Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. 2014! I'll let the JSC guys comment on APIShims if needed. r+ for everything else. Comment on attachment 220873 [details] [PATCH] Proposed Fix Attachment 220873 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/5933584024076288 Created attachment 220883 [details]
[PATCH] For Bots 1
I'll try including the Subdirectory in the forwarding path. So:
- Source/WebCore/ForwardingHeaders/inspector/InspectorAgent.h
+ Source/WebCore/ForwardingHeaders/inspector/agent/InspectorAgent.h
Comment on attachment 220883 [details] [PATCH] For Bots 1 Attachment 220883 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/5845173598683136 Created attachment 220892 [details]
[PATCH] For Bots 2
Comment on attachment 220873 [details] [PATCH] Proposed Fix Attachment 220873 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/5179575134846976 Woot, this looks good! Landed: <http://trac.webkit.org/changeset/161733> |