Bug 126753

Summary:

DOMWindow::showModalDialog should use std::function

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Anders Carlsson 2014-01-10 08:51:04 PST

DOMWindow::showModalDialog should use std::function

Comment 1 Anders Carlsson 2014-01-10 08:52:04 PST

Created attachment 220847 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-10 08:54:27 PST

Attachment 220847 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/page/DOMWindow.h:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.h:445:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2015:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2122:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2014-01-10 09:03:54 PST

Committed r161639: <http://trac.webkit.org/changeset/161639>