| Summary: | Fix building with SVG support disabled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, aperez, commit-queue, dbates, koivisto, rego | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 220842 [details]
Patch
Comment on attachment 220842 [details] Patch LGTM, r=me. It is a correct fix after r161589. Comment on attachment 220842 [details] Patch Rejecting attachment 220842 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 220842, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/FontFastPath.cpp Hunk #1 FAILED at 228. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/FontFastPath.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Csaba Osztrogon\xe1c']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5006518286024704 It was already fixed at http://trac.webkit.org/changeset/161652 |
Created attachment 220840 [details] Patch Building with SVG disabled fails due to a stray closing brace inside the #if ENABLED(SVG) block. Moving the brace fixes the compilation failure.