Bug 126735

Summary:

Fix a build break on EFL debug build

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Gyuyoung Kim 2014-01-09 21:53:02 PST

There is a build error when compiling EFL debug build.


[ 14%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o
/home/gyuyoung/webkit/WebKit/Source/WebCore/platform/ThreadTimers.cpp: In member function ‘void WebCore::ThreadTimers::sharedTimerFiredInternal()’:
/home/gyuyoung/webkit/WebKit/Source/WebCore/platform/ThreadTimers.cpp:112:5: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
cc1plus: all warnings being treated as errors
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o] Error 1
make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2

Comment 1 Gyuyoung Kim 2014-01-09 21:57:36 PST

Created attachment 220801 [details]
Patch

Comment 2 Anders Carlsson 2014-01-09 22:10:15 PST

Comment on attachment 220801 [details]
Patch

Patch looks good since it doesn't change the meaning, but this makes me wonder what the assertion is there for at all!

Comment 3 Gyuyoung Kim 2014-01-09 22:18:21 PST

Comment on attachment 220801 [details]
Patch

Clearing flags on attachment: 220801

Committed r161621: <http://trac.webkit.org/changeset/161621>

Comment 4 Gyuyoung Kim 2014-01-09 22:18:27 PST

All reviewed patches have been landed.  Closing bug.