Bug 126726

Summary: Remove Blackberry and QNX bits from WTF
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126715    
Attachments:
Description Flags
Patch benjamin: review+

Anders Carlsson
Reported 2014-01-09 16:14:48 PST
Remove Blackberry and QNX bits from WTF
Attachments
Patch (24.29 KB, patch)
2014-01-09 16:16 PST, Anders Carlsson 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-09 16:16:59 PST
Created attachment 220786 [details] Patch
Benjamin Poulain
Comment 2 2014-01-09 16:20:09 PST
Comment on attachment 220786 [details] Patch lgtm
WebKit Commit Bot
Comment 3 2014-01-09 16:20:15 PST
Attachment 220786 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Atomics.h', u'Source/WTF/wtf/CurrentTime.cpp', u'Source/WTF/wtf/DateMath.cpp', u'Source/WTF/wtf/DisallowCType.h', u'Source/WTF/wtf/FeatureDefines.h', u'Source/WTF/wtf/InlineASM.h', u'Source/WTF/wtf/MathExtras.h', u'Source/WTF/wtf/NumberOfCores.cpp', u'Source/WTF/wtf/OSAllocatorPosix.cpp', u'Source/WTF/wtf/Platform.h', u'Source/WTF/wtf/PlatformBlackBerry.cmake', u'Source/WTF/wtf/RAMSize.cpp', u'Source/WTF/wtf/StackBounds.cpp', u'Source/WTF/wtf/ThreadingPthreads.cpp', u'Source/WTF/wtf/blackberry/MainThreadBlackBerry.cpp', u'Source/WTF/wtf/blackberry/RunLoopBlackBerry.cpp', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', '--commit-queue']" exit_code: 1 ERROR: Source/WTF/wtf/InlineASM.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2014-01-09 16:27:07 PST
Committed r161601: <http://trac.webkit.org/changeset/161601>
Note You need to log in before you can comment on or make changes to this bug.