Bug 126717

Summary: Web Inspector: Consolidate developerExtrasEnabled to just InspectorEnvironment
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, mkwst, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-01-09 13:49:33 PST
Currently there are multiple inspector agents (Inspector, Console) that have developerExtrasEnabled checks. They all route to InspectorEnvironment (*InspectorController), so just use the InspectorEnvironment call directly. Note, all WebCore agents have InstrumentingAgents, so put InspectorEnvironment on InstrumentingAgents to make it available to all agents.
Attachments
[PATCH] Proposed Fix (19.73 KB, patch)
2014-01-09 13:51 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-09 13:51:11 PST
<rdar://problem/15785810>
Joseph Pecoraro
Comment 2 2014-01-09 13:51:21 PST
Created attachment 220766 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2014-01-09 14:49:23 PST
Comment on attachment 220766 [details] [PATCH] Proposed Fix Clearing flags on attachment: 220766 Committed r161588: <http://trac.webkit.org/changeset/161588>
WebKit Commit Bot
Comment 4 2014-01-09 14:49:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.