Bug 126700

Summary:

Disconnect child frames iteratively

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2014-01-09 08:26:10 PST

Get rid of the odd ChildFrameDisconnector factoring too.

Comment 1 Antti Koivisto 2014-01-09 08:46:11 PST

Created attachment 220743 [details]
patch

Comment 2 Andreas Kling 2014-01-09 08:55:01 PST

Comment on attachment 220743 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220743&action=review

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:171
> +        HTMLFrameOwnerElement& owner = frameOwners[i].get();

I'd use auto& here, since the type is repeated.

Comment 3 Antti Koivisto 2014-01-09 12:07:54 PST

ttps://trac.webkit.org/r161567