Bug 126699

Summary: Regression: failing RegExp tests on 32 bit architectures.
Product: WebKit Reporter: Balazs Kilvady <kilvadyb>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, fpizlo, fu, gergely, ggaren, jbriance, mhahnenberg, msaboff, oliver, palfia
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Description Balazs Kilvady 2014-01-09 08:01:24 PST 
setRegExpConstructorInput and setRegExpConstructorMultiline functions are defined with (ExecState*, JSObject*, JSValue) parameters but are called with (ExecState*, EncodedJSValue, EncodedJSValue) parameters:

(gdb) p entry->m_u.property.put
$6 = (JSC::PutFunction) 0x7791feac <JSC::setRegExpConstructorMultiline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue)>
(gdb) ptype entry->m_u.property.put
type = void (*)(JSC::ExecState *, JSC::EncodedJSValue, JSC::EncodedJSValue)
Comment 1 Balazs Kilvady 2014-01-09 08:11:26 PST 
Created attachment 220737 [details]
proposed patch.
Comment 2 Oliver Hunt 2014-01-09 10:29:20 PST 
Comment on attachment 220737 [details]
proposed patch.

whoops, sorry
Comment 3 WebKit Commit Bot 2014-01-09 10:42:24 PST 
Comment on attachment 220737 [details]
proposed patch.

Clearing flags on attachment: 220737

Committed r161562: <http://trac.webkit.org/changeset/161562>
Comment 4 WebKit Commit Bot 2014-01-09 10:42:26 PST 
All reviewed patches have been landed.  Closing bug.