Bug 126696

Summary: DocumentOrderedMap should use iterator
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
better patch kling: review+

Antti Koivisto
Reported 2014-01-09 07:38:38 PST
Instead of ElementTraversal
Attachments
patch (4.21 KB, patch)
2014-01-09 07:52 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
better patch (7.82 KB, patch)
2014-01-09 08:15 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-01-09 07:52:26 PST
Created attachment 220734 [details] patch
Antti Koivisto
Comment 2 2014-01-09 08:15:08 PST
Created attachment 220738 [details] better patch
Andreas Kling
Comment 3 2014-01-09 08:48:35 PST
Comment on attachment 220738 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=220738&action=review > Source/WebCore/dom/DocumentOrderedMap.cpp:213 > + auto elementDescandants = descendantsOfType<Element>(*scope.rootNode()); Typo, descandants. > Source/WebCore/dom/DocumentOrderedMap.cpp:214 > + auto it = entry.element ? elementDescandants.find(*entry.element) : elementDescandants.begin(); We need a better name for find(). beginAt()?
Antti Koivisto
Comment 4 2014-01-09 12:18:26 PST
https://trac.webkit.org/r161572
Note You need to log in before you can comment on or make changes to this bug.