Bug 126695

Summary: Possible crash in ApplicationCache::removeResource
Product: WebKit Reporter: Piotr Grad <piotr.grad>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Piotr Grad
Reported 2014-01-09 07:09:28 PST
"Iterator it" variable is used after is removed. Working on patch, will be proposed soon.
Attachments
Patch (1.28 KB, patch)
2014-01-09 07:13 PST, Piotr Grad 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2014-01-09 14:15 PST, Piotr Grad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Piotr Grad
Comment 1 2014-01-09 07:13:36 PST
Created attachment 220730 [details] Patch
Piotr Grad
Comment 2 2014-01-09 08:36:39 PST
Comment on attachment 220730 [details] Patch mac-wk2 is not passing also with other attachments with same output.
Alexey Proskuryakov
Comment 3 2014-01-09 09:16:43 PST
Comment on attachment 220730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220730&action=review > Source/WebCore/ChangeLog:8 > + No new tests. This is not a very helpful line. You could explain _why_ there are no tests, but even that is better to do in the bug, not in ChangeLog I think.
Piotr Grad
Comment 4 2014-01-09 14:15:51 PST
Created attachment 220768 [details] Patch
WebKit Commit Bot
Comment 5 2014-01-10 13:04:50 PST
Comment on attachment 220730 [details] Patch Clearing flags on attachment: 220730 Committed r161665: <http://trac.webkit.org/changeset/161665>
WebKit Commit Bot
Comment 6 2014-01-10 13:04:52 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2014-01-10 13:14:40 PST
Comment on attachment 220730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220730&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests. > > This is not a very helpful line. You could explain _why_ there are no tests, but even that is better to do in the bug, not in ChangeLog I think. Given that our iterators are checked, I think we could indeed make a test for this. If we can get this code to run, it should assert in a debug build. This fix should not have gone in without a test!
Note You need to log in before you can comment on or make changes to this bug.