| Summary: | [GTK] Fails to build if configure is run with its absolute path | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 220725 [details]
Patch
Committed r163956: <http://trac.webkit.org/changeset/163956> |
There's a couple of links from the build dir to the webkit 2 headers in the source dir that are created like this: ln -s -f ${shell pwd}/$(WebKit2)/UIProcess/API/gtk $@ ln -s -f ${shell pwd}/$(WebKit2)/WebProcess/InjectedBundle/API/gtk $@ Problem is, that works if $(WebKit2) is a relative path, e.g if we create the build dir inside the webkit source tree and run ../configure: ln -s -f /tmp/webkit/build/../Source/WebKit2/WebProcess/InjectedBundle/API/gtk DerivedSources/WebKit2/webkit2extension/include/webkit2 ln -s -f /tmp/webkit/build/../Source/WebKit2/UIProcess/API/gtk DerivedSources/WebKit2/webkit2gtk/include/webkit2 However if we use an absolute path (/tmp/webkit/configure in this example) we get a broken link: ln -s -f /tmp/webkit/build//tmp/webkit/Source/WebKit2/WebProcess/InjectedBundle/API/gtk DerivedSources/WebKit2/webkit2extension/include/webkit2 ln -s -f /tmp/webkit/build//tmp/webkit/Source/WebKit2/UIProcess/API/gtk DerivedSources/WebKit2/webkit2gtk/include/webkit2 A quick fix is to replace the makefile recipe with something like this: ln -s -f ${shell cd $(WebKit2)/UIProcess/API/gtk && pwd} $@ ln -s -f ${shell cd $(WebKit2)/WebProcess/InjectedBundle/API/gtk && pwd} $@