| Summary: | Remove extra includes from FTL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Molnar <pmolnar.u-szeged> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | fpizlo, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Molnar
2014-01-09 06:19:02 PST
Created attachment 220721 [details]
patch
Comment on attachment 220721 [details]
patch
r=me if this still applies/builds.
Created attachment 223696 [details]
patch
(In reply to comment #2) > (From update of attachment 220721 [details]) > r=me if this still applies/builds. No, it doesn't apply, updated the patch. (In reply to comment #2) > (From update of attachment 220721 [details]) > r=me if this still applies/builds. Note that EWS isn't building or testing FTL right now. I don't like this patch at all. You're basically trying to come up with the minimal set of include statements that works, but that relies on a lot of inclusion. This means that if we cleaned up some of the headers to include fewer things, we'd need to add back the include statements that you removed. I don't like this at all; such changes are just pure noise and add nothing to the project. Comment on attachment 223696 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=223696&action=review > Source/JavaScriptCore/ftl/FTLAbbreviations.h:-33 > -#include "FTLAbbreviatedTypes.h" This is very suspicious. Comment on attachment 220721 [details] patch Cleared Andreas Kling's review+ from obsolete attachment 220721 [details] so that this bug does not appear in http://webkit.org/pending-commit. |