Bug 126691

Summary: Remove extra includes from FTL
Product: WebKit Reporter: Peter Molnar <pmolnar.u-szeged>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: fpizlo, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch fpizlo: review-, fpizlo: commit-queue-

Peter Molnar
Reported 2014-01-09 06:19:02 PST
Remove extra includes from FTL
Attachments
patch (12.82 KB, patch)
2014-01-09 06:19 PST, Peter Molnar 		no flags
DetailsFormatted DiffDiff
patch (11.96 KB, patch)
2014-02-10 04:39 PST, Peter Molnar 		fpizlo: review-
fpizlo: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Molnar
Comment 1 2014-01-09 06:19:56 PST
Created attachment 220721 [details] patch
Andreas Kling
Comment 2 2014-02-07 02:10:27 PST
Comment on attachment 220721 [details] patch r=me if this still applies/builds.
Peter Molnar
Comment 3 2014-02-10 04:39:31 PST
Created attachment 223696 [details] patch
Peter Molnar
Comment 4 2014-02-10 04:39:56 PST
(In reply to comment #2) > (From update of attachment 220721 [details]) > r=me if this still applies/builds. No, it doesn't apply, updated the patch.
Filip Pizlo
Comment 5 2014-02-10 08:09:08 PST
(In reply to comment #2) > (From update of attachment 220721 [details]) > r=me if this still applies/builds. Note that EWS isn't building or testing FTL right now.
Filip Pizlo
Comment 6 2014-02-10 08:11:47 PST
I don't like this patch at all. You're basically trying to come up with the minimal set of include statements that works, but that relies on a lot of inclusion. This means that if we cleaned up some of the headers to include fewer things, we'd need to add back the include statements that you removed. I don't like this at all; such changes are just pure noise and add nothing to the project.
Filip Pizlo
Comment 7 2014-02-10 08:12:13 PST
Comment on attachment 223696 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=223696&action=review > Source/JavaScriptCore/ftl/FTLAbbreviations.h:-33 > -#include "FTLAbbreviatedTypes.h" This is very suspicious.
Csaba Osztrogonác
Comment 8 2014-02-13 04:12:24 PST
Comment on attachment 220721 [details] patch Cleared Andreas Kling's review+ from obsolete attachment 220721 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Note You need to log in before you can comment on or make changes to this bug.