Bug 126676

Summary:

Web Inspector: Correctly track time bounds of WebInspector.Timeline and WebInspector.TimelineRecording

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	timothy: commit-queue-

Description Timothy Hatcher 2014-01-08 19:07:40 PST

The startTime and endTime were not correct when Network timeline needed to be taken into account (due to its dynamic loading nature.)

Comment 1 Radar WebKit Bug Importer 2014-01-08 19:08:24 PST

<rdar://problem/15778935>

Comment 2 Timothy Hatcher 2014-01-08 19:11:56 PST

Created attachment 220690 [details]
Patch

Comment 3 Joseph Pecoraro 2014-01-09 13:35:17 PST

Comment on attachment 220690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220690&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:64
> +            }.bind(this));

You could use the thisObject optional param to Map.prototype.forEach. E.g.:

    forEach(function() {...}, this);

instead of

    forEach(function() {...}.bind(this));

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:74
> +        }.bind(this));

Ditto

Comment 4 Timothy Hatcher 2014-01-10 15:01:43 PST

Created attachment 220894 [details]
Patch

Comment 5 Timothy Hatcher 2014-01-20 19:00:55 PST

https://trac.webkit.org/changeset/162402