Bug 126661

Summary:

Clean up confusing names and calculations in image-dragging functions

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Images

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

125375

Attachments:

Description	Flags
patch	none

Description BJ Burg 2014-01-08 13:31:27 PST

Several functions used to implement image dragging have unhelpful variable names and scale-related calculations that could be simpler. This led to mistakes where the wrong scale was applied.

Comment 1 BJ Burg 2014-01-08 13:41:23 PST

Created attachment 220661 [details]
patch

Comment 2 WebKit Commit Bot 2014-01-08 18:17:51 PST

Comment on attachment 220661 [details]
patch

Clearing flags on attachment: 220661

Committed r161537: <http://trac.webkit.org/changeset/161537>

Comment 3 WebKit Commit Bot 2014-01-08 18:17:53 PST

All reviewed patches have been landed.  Closing bug.