Bug 126661

Summary: Clean up confusing names and calculations in image-dragging functions
Product: WebKit Reporter: Blaze Burg <bburg>
Component: ImagesAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125375    
Attachments:
Description Flags
patch none

Blaze Burg
Reported 2014-01-08 13:31:27 PST
Several functions used to implement image dragging have unhelpful variable names and scale-related calculations that could be simpler. This led to mistakes where the wrong scale was applied.
Attachments
patch (6.65 KB, patch)
2014-01-08 13:41 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2014-01-08 13:41:23 PST
Created attachment 220661 [details] patch
WebKit Commit Bot
Comment 2 2014-01-08 18:17:51 PST
Comment on attachment 220661 [details] patch Clearing flags on attachment: 220661 Committed r161537: <http://trac.webkit.org/changeset/161537>
WebKit Commit Bot
Comment 3 2014-01-08 18:17:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.