Bug 126654

Summary:

[iOS] Upstream WebCore/platform changes

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Platform

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, buildbot, cgarcia, commit-queue, darin, ddkilzer, eflews.bot, enrica, gyuyoung.kim, joepeck, jpetsovits, ljaehun.lim, ltilve+ews, mrobinson, rniwa, sam, simon.fraser, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ddkilzer: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none

Daniel Bates

Reported 2014-01-08 12:13:50 PST

Upstream the iOS changes to WebCore/platform.

Attachments
Patch (970.81 KB, patch) 2014-01-08 12:15 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (970.84 KB, patch) 2014-01-08 12:46 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (970.85 KB, patch) 2014-01-08 12:52 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (1.01 MB, patch) 2014-01-08 14:55 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (1.01 MB, patch) 2014-01-08 20:47 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (1.01 MB, patch) 2014-01-09 07:40 PST, Daniel Bates	ddkilzer: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (452.53 KB, application/zip) 2014-01-09 08:46 PST, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2014-01-08 12:15:47 PST

Created attachment 220650 [details] Patch

WebKit Commit Bot

Comment 2 2014-01-08 12:18:20 PST

Attachment 220650 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/ContentFilter.h', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/FileChooser.cpp', u'Source/WebCore/platform/FileChooser.h', u'Source/WebCore/platform/FileSystem.cpp', u'Source/WebCore/platform/FileSystem.h', u'Source/WebCore/platform/KillRingNone.cpp', u'Source/WebCore/platform/LocalizedStrings.cpp', u'Source/WebCore/platform/LocalizedStrings.h', u'Source/WebCore/platform/Logging.h', u'Source/WebCore/platform/MIMETypeRegistry.cpp', u'Source/WebCore/platform/MemoryPressureHandler.cpp', u'Source/WebCore/platform/MemoryPressureHandler.h', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformScreen.h', u'Source/WebCore/platform/RuntimeApplicationChecks.cpp', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.h', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.mm', u'Source/WebCore/platform/ScrollAnimator.cpp', u'Source/WebCore/platform/ScrollAnimator.h', u'Source/WebCore/platform/ScrollTypes.h', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/platform/ScrollableArea.cpp', u'Source/WebCore/platform/ScrollableArea.h', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/Scrollbar.h', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/SharedBuffer.h', u'Source/WebCore/platform/SuddenTermination.h', u'Source/WebCore/platform/Supplementable.h', u'Source/WebCore/platform/SystemMemory.h', u'Source/WebCore/platform/ThreadCheck.h', u'Source/WebCore/platform/ThreadGlobalData.cpp', u'Source/WebCore/platform/ThreadGlobalData.h', u'Source/WebCore/platform/ThreadTimers.cpp', u'Source/WebCore/platform/Timer.cpp', u'Source/WebCore/platform/Timer.h', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/URL.h', u'Source/WebCore/platform/Widget.h', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.h', u'Source/WebCore/platform/audio/ios/AudioSessionIOS.mm', u'Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp', u'Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp', u'Source/WebCore/platform/audio/mac/AudioSessionMac.cpp', u'Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp', u'Source/WebCore/platform/cf/SharedBufferCF.cpp', u'Source/WebCore/platform/cf/URLCF.cpp', u'Source/WebCore/platform/cocoa/KeyEventCocoa.mm', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/Color.cpp', u'Source/WebCore/platform/graphics/Color.h', u'Source/WebCore/platform/graphics/DisplayRefreshMonitor.h', u'Source/WebCore/platform/graphics/FloatPoint.h', u'Source/WebCore/platform/graphics/FloatRect.h', u'Source/WebCore/platform/graphics/FloatSize.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontPlatformData.cpp', u'Source/WebCore/platform/graphics/FontPlatformData.h', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/Icon.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/IntPoint.h', u'Source/WebCore/platform/graphics/IntRect.h', u'Source/WebCore/platform/graphics/IntSize.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/SimpleFontData.cpp', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/StringTruncator.h', u'Source/WebCore/platform/graphics/TextTrackRepresentation.cpp', u'Source/WebCore/platform/graphics/WidthIterator.h', u'Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAFilters.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp', u'Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ColorCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatPointCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatRectCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/GradientCG.cpp', u'Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCGMac.mm', u'Source/WebCore/platform/graphics/cg/IntPointCG.cpp', u'Source/WebCore/platform/graphics/cg/IntRectCG.cpp', u'Source/WebCore/platform/graphics/cg/IntSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp', u'Source/WebCore/platform/graphics/cg/PathCG.cpp', u'Source/WebCore/platform/graphics/cg/PatternCG.cpp', u'Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm', u'Source/WebCore/platform/graphics/ios/DisplayRefreshMonitoriOS.mm', u'Source/WebCore/platform/graphics/ios/FontCacheIOS.mm', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.h', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.mm', u'Source/WebCore/platform/graphics/ios/GraphicsContext3DIOS.h', u'Source/WebCore/platform/graphics/ios/IconIOS.mm', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.h', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.mm', u'Source/WebCore/platform/graphics/ios/SimpleFontDataIOS.mm', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.h', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm', u'Source/WebCore/platform/graphics/mac/ColorMac.h', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm', u'Source/WebCore/platform/graphics/mac/FloatPointMac.mm', u'Source/WebCore/platform/graphics/mac/FloatRectMac.mm', u'Source/WebCore/platform/graphics/mac/FloatSizeMac.mm', u'Source/WebCore/platform/graphics/mac/FontCacheMac.mm', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp', u'Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp', u'Source/WebCore/platform/graphics/mac/FontMac.mm', u'Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm', u'Source/WebCore/platform/graphics/mac/IconMac.mm', u'Source/WebCore/platform/graphics/mac/ImageMac.mm', u'Source/WebCore/platform/graphics/mac/IntPointMac.mm', u'Source/WebCore/platform/graphics/mac/IntRectMac.mm', u'Source/WebCore/platform/graphics/mac/IntSizeMac.mm', u'Source/WebCore/platform/graphics/mac/MediaPlayerProxy.h', u'Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp', u'Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm', u'Source/WebCore/platform/graphics/mac/WebGLLayer.h', u'Source/WebCore/platform/graphics/mac/WebGLLayer.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebCore/platform/graphics/mac/WebTiledLayer.mm', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp', u'Source/WebCore/platform/graphics/win/FontWin.cpp', u'Source/WebCore/platform/graphics/wince/FontWinCE.cpp', u'Source/WebCore/platform/ios/ContentFilterIOS.mm', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.h', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.mm', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.h', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm', u'Source/WebCore/platform/ios/KeyEventIOS.mm', u'Source/WebCore/platform/ios/MIMETypeRegistryIOS.mm', u'Source/WebCore/platform/ios/MemoryPressureHandlerIOS.mm', u'Source/WebCore/platform/ios/PasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.h', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm', u'Source/WebCore/platform/ios/PlatformPasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformScreenIOS.mm', u'Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm', u'Source/WebCore/platform/ios/SSLKeyGeneratorIOS.cpp', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.h', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.mm', u'Source/WebCore/platform/ios/ScrollViewIOS.mm', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.h', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.mm', u'Source/WebCore/platform/ios/SelectionRect.cpp', u'Source/WebCore/platform/ios/SelectionRect.h', u'Source/WebCore/platform/ios/SoundIOS.mm', u'Source/WebCore/platform/ios/SystemMemoryIOS.cpp', u'Source/WebCore/platform/ios/ThemeIOS.h', u'Source/WebCore/platform/ios/ThemeIOS.mm', u'Source/WebCore/platform/ios/TileCache.h', u'Source/WebCore/platform/ios/TileCache.mm', u'Source/WebCore/platform/ios/TileGrid.h', u'Source/WebCore/platform/ios/TileGrid.mm', u'Source/WebCore/platform/ios/TileGridTile.h', u'Source/WebCore/platform/ios/TileGridTile.mm', u'Source/WebCore/platform/ios/TileLayer.h', u'Source/WebCore/platform/ios/TileLayer.mm', u'Source/WebCore/platform/ios/TileLayerPool.h', u'Source/WebCore/platform/ios/TileLayerPool.mm', u'Source/WebCore/platform/ios/WebCoreMotionManager.h', u'Source/WebCore/platform/ios/WebCoreMotionManager.mm', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.h', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm', u'Source/WebCore/platform/ios/WebEvent.h', u'Source/WebCore/platform/ios/WebEvent.mm', u'Source/WebCore/platform/ios/WidgetIOS.mm', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.h', u'Source/WebCore/platform/mac/FileSystemMac.mm', u'Source/WebCore/platform/mac/KillRingMac.mm', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/mac/PlatformClockCM.mm', u'Source/WebCore/platform/mac/SoftLinking.h', u'Source/WebCore/platform/mac/SystemVersionMac.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.h', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.m', u'Source/WebCore/platform/mac/WebCoreSystemInterface.h', u'Source/WebCore/platform/mac/WebFontCache.mm', u'Source/WebCore/platform/network/BlobRegistry.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/Credential.h', u'Source/WebCore/platform/network/CredentialStorage.cpp', u'Source/WebCore/platform/network/CredentialStorage.h', u'Source/WebCore/platform/network/NetworkStateNotifier.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.h', u'Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp', u'Source/WebCore/platform/network/cf/DNSCFNet.cpp', u'Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequest.h', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp', u'Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.cpp', u'Source/WebCore/platform/network/ios/QuickLook.h', u'Source/WebCore/platform/network/ios/QuickLook.mm', u'Source/WebCore/platform/network/ios/ResourceHandleIOS.mm', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm', u'Source/WebCore/platform/network/mac/AuthenticationMac.mm', u'Source/WebCore/platform/network/mac/CredentialStorageMac.mm', u'Source/WebCore/platform/network/mac/ResourceErrorMac.mm', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/ResourceRequestMac.mm', u'Source/WebCore/platform/network/mac/UTIUtilities.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm', u'Source/WebCore/platform/sql/SQLiteDatabase.h', u'Source/WebCore/platform/sql/SQLiteFileSystem.cpp', u'Source/WebCore/platform/sql/SQLiteFileSystem.h', u'Source/WebCore/platform/sql/SQLiteTransaction.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h', u'Source/WebCore/platform/text/PlatformLocale.cpp', u'Source/WebCore/platform/text/PlatformLocale.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/platform/text/cf/HyphenationCF.cpp', u'Source/WebCore/platform/text/ios/LocalizedDateCache.h', u'Source/WebCore/platform/text/ios/LocalizedDateCache.mm', u'Source/WebCore/platform/text/mac/CharsetData.h', u'Source/WebCore/platform/text/mac/LocaleMac.h', u'Source/WebCore/platform/text/mac/LocaleMac.mm', u'Source/WebCore/platform/text/mac/TextBoundaries.mm', u'Source/WebCore/platform/text/mac/TextCodecMac.cpp', u'Source/WebCore/platform/text/mac/TextCodecMac.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/ios/WebEvent.h:27: #ifndef header guard has wrong style, please use: WebEvent_h [build/header_guard] [5] ERROR: Source/WebCore/platform/ios/WebEvent.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/ScrollAnimatorIOS.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:143: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:250: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:74: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:67: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:71: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1041: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1099: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:52: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:53: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:54: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/mac/SoftLinking.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:122: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:45: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:50: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontPlatformData.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:54: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:55: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:57: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:58: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:59: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:60: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:61: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:62: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:63: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:64: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:65: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:66: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:67: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:68: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 79 in 280 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 3 2014-01-08 12:35:02 PST

Comment on attachment 220650 [details] Patch Attachment 220650 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4509973627273216

Daniel Bates

Comment 4 2014-01-08 12:46:59 PST

Created attachment 220655 [details] Patch

WebKit Commit Bot

Comment 5 2014-01-08 12:48:46 PST

Attachment 220655 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/ContentFilter.h', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/FileChooser.cpp', u'Source/WebCore/platform/FileChooser.h', u'Source/WebCore/platform/FileSystem.cpp', u'Source/WebCore/platform/FileSystem.h', u'Source/WebCore/platform/KillRingNone.cpp', u'Source/WebCore/platform/LocalizedStrings.cpp', u'Source/WebCore/platform/LocalizedStrings.h', u'Source/WebCore/platform/Logging.h', u'Source/WebCore/platform/MIMETypeRegistry.cpp', u'Source/WebCore/platform/MemoryPressureHandler.cpp', u'Source/WebCore/platform/MemoryPressureHandler.h', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformScreen.h', u'Source/WebCore/platform/RuntimeApplicationChecks.cpp', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.h', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.mm', u'Source/WebCore/platform/ScrollAnimator.cpp', u'Source/WebCore/platform/ScrollAnimator.h', u'Source/WebCore/platform/ScrollTypes.h', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/platform/ScrollableArea.cpp', u'Source/WebCore/platform/ScrollableArea.h', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/Scrollbar.h', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/SharedBuffer.h', u'Source/WebCore/platform/SuddenTermination.h', u'Source/WebCore/platform/Supplementable.h', u'Source/WebCore/platform/SystemMemory.h', u'Source/WebCore/platform/ThreadCheck.h', u'Source/WebCore/platform/ThreadGlobalData.cpp', u'Source/WebCore/platform/ThreadGlobalData.h', u'Source/WebCore/platform/ThreadTimers.cpp', u'Source/WebCore/platform/Timer.cpp', u'Source/WebCore/platform/Timer.h', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/URL.h', u'Source/WebCore/platform/Widget.h', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.h', u'Source/WebCore/platform/audio/ios/AudioSessionIOS.mm', u'Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp', u'Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp', u'Source/WebCore/platform/audio/mac/AudioSessionMac.cpp', u'Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp', u'Source/WebCore/platform/cf/SharedBufferCF.cpp', u'Source/WebCore/platform/cf/URLCF.cpp', u'Source/WebCore/platform/cocoa/KeyEventCocoa.mm', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/Color.cpp', u'Source/WebCore/platform/graphics/Color.h', u'Source/WebCore/platform/graphics/DisplayRefreshMonitor.h', u'Source/WebCore/platform/graphics/FloatPoint.h', u'Source/WebCore/platform/graphics/FloatRect.h', u'Source/WebCore/platform/graphics/FloatSize.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontPlatformData.cpp', u'Source/WebCore/platform/graphics/FontPlatformData.h', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/Icon.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/IntPoint.h', u'Source/WebCore/platform/graphics/IntRect.h', u'Source/WebCore/platform/graphics/IntSize.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/SimpleFontData.cpp', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/StringTruncator.h', u'Source/WebCore/platform/graphics/TextTrackRepresentation.cpp', u'Source/WebCore/platform/graphics/WidthIterator.h', u'Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAFilters.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp', u'Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ColorCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatPointCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatRectCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/GradientCG.cpp', u'Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCGMac.mm', u'Source/WebCore/platform/graphics/cg/IntPointCG.cpp', u'Source/WebCore/platform/graphics/cg/IntRectCG.cpp', u'Source/WebCore/platform/graphics/cg/IntSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp', u'Source/WebCore/platform/graphics/cg/PathCG.cpp', u'Source/WebCore/platform/graphics/cg/PatternCG.cpp', u'Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm', u'Source/WebCore/platform/graphics/ios/DisplayRefreshMonitoriOS.mm', u'Source/WebCore/platform/graphics/ios/FontCacheIOS.mm', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.h', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.mm', u'Source/WebCore/platform/graphics/ios/GraphicsContext3DIOS.h', u'Source/WebCore/platform/graphics/ios/IconIOS.mm', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.h', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.mm', u'Source/WebCore/platform/graphics/ios/SimpleFontDataIOS.mm', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.h', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm', u'Source/WebCore/platform/graphics/mac/ColorMac.h', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm', u'Source/WebCore/platform/graphics/mac/FloatPointMac.mm', u'Source/WebCore/platform/graphics/mac/FloatRectMac.mm', u'Source/WebCore/platform/graphics/mac/FloatSizeMac.mm', u'Source/WebCore/platform/graphics/mac/FontCacheMac.mm', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp', u'Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp', u'Source/WebCore/platform/graphics/mac/FontMac.mm', u'Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm', u'Source/WebCore/platform/graphics/mac/IconMac.mm', u'Source/WebCore/platform/graphics/mac/ImageMac.mm', u'Source/WebCore/platform/graphics/mac/IntPointMac.mm', u'Source/WebCore/platform/graphics/mac/IntRectMac.mm', u'Source/WebCore/platform/graphics/mac/IntSizeMac.mm', u'Source/WebCore/platform/graphics/mac/MediaPlayerProxy.h', u'Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp', u'Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm', u'Source/WebCore/platform/graphics/mac/WebGLLayer.h', u'Source/WebCore/platform/graphics/mac/WebGLLayer.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebCore/platform/graphics/mac/WebTiledLayer.mm', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp', u'Source/WebCore/platform/graphics/win/FontWin.cpp', u'Source/WebCore/platform/graphics/wince/FontWinCE.cpp', u'Source/WebCore/platform/ios/ContentFilterIOS.mm', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.h', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.mm', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.h', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm', u'Source/WebCore/platform/ios/KeyEventIOS.mm', u'Source/WebCore/platform/ios/MIMETypeRegistryIOS.mm', u'Source/WebCore/platform/ios/MemoryPressureHandlerIOS.mm', u'Source/WebCore/platform/ios/PasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.h', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm', u'Source/WebCore/platform/ios/PlatformPasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformScreenIOS.mm', u'Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm', u'Source/WebCore/platform/ios/SSLKeyGeneratorIOS.cpp', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.h', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.mm', u'Source/WebCore/platform/ios/ScrollViewIOS.mm', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.h', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.mm', u'Source/WebCore/platform/ios/SelectionRect.cpp', u'Source/WebCore/platform/ios/SelectionRect.h', u'Source/WebCore/platform/ios/SoundIOS.mm', u'Source/WebCore/platform/ios/SystemMemoryIOS.cpp', u'Source/WebCore/platform/ios/ThemeIOS.h', u'Source/WebCore/platform/ios/ThemeIOS.mm', u'Source/WebCore/platform/ios/TileCache.h', u'Source/WebCore/platform/ios/TileCache.mm', u'Source/WebCore/platform/ios/TileGrid.h', u'Source/WebCore/platform/ios/TileGrid.mm', u'Source/WebCore/platform/ios/TileGridTile.h', u'Source/WebCore/platform/ios/TileGridTile.mm', u'Source/WebCore/platform/ios/TileLayer.h', u'Source/WebCore/platform/ios/TileLayer.mm', u'Source/WebCore/platform/ios/TileLayerPool.h', u'Source/WebCore/platform/ios/TileLayerPool.mm', u'Source/WebCore/platform/ios/WebCoreMotionManager.h', u'Source/WebCore/platform/ios/WebCoreMotionManager.mm', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.h', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm', u'Source/WebCore/platform/ios/WebEvent.h', u'Source/WebCore/platform/ios/WebEvent.mm', u'Source/WebCore/platform/ios/WidgetIOS.mm', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.h', u'Source/WebCore/platform/mac/FileSystemMac.mm', u'Source/WebCore/platform/mac/KillRingMac.mm', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/mac/PlatformClockCM.mm', u'Source/WebCore/platform/mac/SoftLinking.h', u'Source/WebCore/platform/mac/SystemVersionMac.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.h', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.m', u'Source/WebCore/platform/mac/WebCoreSystemInterface.h', u'Source/WebCore/platform/mac/WebFontCache.mm', u'Source/WebCore/platform/network/BlobRegistry.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/Credential.h', u'Source/WebCore/platform/network/CredentialStorage.cpp', u'Source/WebCore/platform/network/CredentialStorage.h', u'Source/WebCore/platform/network/NetworkStateNotifier.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.h', u'Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp', u'Source/WebCore/platform/network/cf/DNSCFNet.cpp', u'Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequest.h', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp', u'Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.cpp', u'Source/WebCore/platform/network/ios/QuickLook.h', u'Source/WebCore/platform/network/ios/QuickLook.mm', u'Source/WebCore/platform/network/ios/ResourceHandleIOS.mm', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm', u'Source/WebCore/platform/network/mac/AuthenticationMac.mm', u'Source/WebCore/platform/network/mac/CredentialStorageMac.mm', u'Source/WebCore/platform/network/mac/ResourceErrorMac.mm', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/ResourceRequestMac.mm', u'Source/WebCore/platform/network/mac/UTIUtilities.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm', u'Source/WebCore/platform/sql/SQLiteDatabase.h', u'Source/WebCore/platform/sql/SQLiteFileSystem.cpp', u'Source/WebCore/platform/sql/SQLiteFileSystem.h', u'Source/WebCore/platform/sql/SQLiteTransaction.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h', u'Source/WebCore/platform/text/PlatformLocale.cpp', u'Source/WebCore/platform/text/PlatformLocale.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/platform/text/cf/HyphenationCF.cpp', u'Source/WebCore/platform/text/ios/LocalizedDateCache.h', u'Source/WebCore/platform/text/ios/LocalizedDateCache.mm', u'Source/WebCore/platform/text/mac/CharsetData.h', u'Source/WebCore/platform/text/mac/LocaleMac.h', u'Source/WebCore/platform/text/mac/LocaleMac.mm', u'Source/WebCore/platform/text/mac/TextBoundaries.mm', u'Source/WebCore/platform/text/mac/TextCodecMac.cpp', u'Source/WebCore/platform/text/mac/TextCodecMac.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/ios/WebEvent.h:27: #ifndef header guard has wrong style, please use: WebEvent_h [build/header_guard] [5] ERROR: Source/WebCore/platform/ios/WebEvent.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/ScrollAnimatorIOS.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:143: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:250: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:74: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:67: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:71: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1041: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1099: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:52: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:53: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:54: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/mac/SoftLinking.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:122: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:45: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:50: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontPlatformData.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:54: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:55: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:57: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:58: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:59: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:60: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:61: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:62: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:63: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:64: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:65: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:66: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:67: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:68: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 79 in 280 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 6 2014-01-08 12:52:24 PST

Created attachment 220656 [details] Patch

WebKit Commit Bot

Comment 7 2014-01-08 12:54:43 PST

Attachment 220656 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/ContentFilter.h', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/FileChooser.cpp', u'Source/WebCore/platform/FileChooser.h', u'Source/WebCore/platform/FileSystem.cpp', u'Source/WebCore/platform/FileSystem.h', u'Source/WebCore/platform/KillRingNone.cpp', u'Source/WebCore/platform/LocalizedStrings.cpp', u'Source/WebCore/platform/LocalizedStrings.h', u'Source/WebCore/platform/Logging.h', u'Source/WebCore/platform/MIMETypeRegistry.cpp', u'Source/WebCore/platform/MemoryPressureHandler.cpp', u'Source/WebCore/platform/MemoryPressureHandler.h', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformScreen.h', u'Source/WebCore/platform/RuntimeApplicationChecks.cpp', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.h', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.mm', u'Source/WebCore/platform/ScrollAnimator.cpp', u'Source/WebCore/platform/ScrollAnimator.h', u'Source/WebCore/platform/ScrollTypes.h', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/platform/ScrollableArea.cpp', u'Source/WebCore/platform/ScrollableArea.h', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/Scrollbar.h', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/SharedBuffer.h', u'Source/WebCore/platform/SuddenTermination.h', u'Source/WebCore/platform/Supplementable.h', u'Source/WebCore/platform/SystemMemory.h', u'Source/WebCore/platform/ThreadCheck.h', u'Source/WebCore/platform/ThreadGlobalData.cpp', u'Source/WebCore/platform/ThreadGlobalData.h', u'Source/WebCore/platform/ThreadTimers.cpp', u'Source/WebCore/platform/Timer.cpp', u'Source/WebCore/platform/Timer.h', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/URL.h', u'Source/WebCore/platform/Widget.h', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.h', u'Source/WebCore/platform/audio/ios/AudioSessionIOS.mm', u'Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp', u'Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp', u'Source/WebCore/platform/audio/mac/AudioSessionMac.cpp', u'Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp', u'Source/WebCore/platform/cf/SharedBufferCF.cpp', u'Source/WebCore/platform/cf/URLCF.cpp', u'Source/WebCore/platform/cocoa/KeyEventCocoa.mm', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/Color.cpp', u'Source/WebCore/platform/graphics/Color.h', u'Source/WebCore/platform/graphics/DisplayRefreshMonitor.h', u'Source/WebCore/platform/graphics/FloatPoint.h', u'Source/WebCore/platform/graphics/FloatRect.h', u'Source/WebCore/platform/graphics/FloatSize.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontPlatformData.cpp', u'Source/WebCore/platform/graphics/FontPlatformData.h', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/Icon.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/IntPoint.h', u'Source/WebCore/platform/graphics/IntRect.h', u'Source/WebCore/platform/graphics/IntSize.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/SimpleFontData.cpp', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/StringTruncator.h', u'Source/WebCore/platform/graphics/TextTrackRepresentation.cpp', u'Source/WebCore/platform/graphics/WidthIterator.h', u'Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAFilters.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp', u'Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ColorCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatPointCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatRectCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/GradientCG.cpp', u'Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCGMac.mm', u'Source/WebCore/platform/graphics/cg/IntPointCG.cpp', u'Source/WebCore/platform/graphics/cg/IntRectCG.cpp', u'Source/WebCore/platform/graphics/cg/IntSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp', u'Source/WebCore/platform/graphics/cg/PathCG.cpp', u'Source/WebCore/platform/graphics/cg/PatternCG.cpp', u'Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm', u'Source/WebCore/platform/graphics/ios/DisplayRefreshMonitoriOS.mm', u'Source/WebCore/platform/graphics/ios/FontCacheIOS.mm', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.h', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.mm', u'Source/WebCore/platform/graphics/ios/GraphicsContext3DIOS.h', u'Source/WebCore/platform/graphics/ios/IconIOS.mm', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.h', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.mm', u'Source/WebCore/platform/graphics/ios/SimpleFontDataIOS.mm', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.h', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm', u'Source/WebCore/platform/graphics/mac/ColorMac.h', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm', u'Source/WebCore/platform/graphics/mac/FloatPointMac.mm', u'Source/WebCore/platform/graphics/mac/FloatRectMac.mm', u'Source/WebCore/platform/graphics/mac/FloatSizeMac.mm', u'Source/WebCore/platform/graphics/mac/FontCacheMac.mm', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp', u'Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp', u'Source/WebCore/platform/graphics/mac/FontMac.mm', u'Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm', u'Source/WebCore/platform/graphics/mac/IconMac.mm', u'Source/WebCore/platform/graphics/mac/ImageMac.mm', u'Source/WebCore/platform/graphics/mac/IntPointMac.mm', u'Source/WebCore/platform/graphics/mac/IntRectMac.mm', u'Source/WebCore/platform/graphics/mac/IntSizeMac.mm', u'Source/WebCore/platform/graphics/mac/MediaPlayerProxy.h', u'Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp', u'Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm', u'Source/WebCore/platform/graphics/mac/WebGLLayer.h', u'Source/WebCore/platform/graphics/mac/WebGLLayer.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebCore/platform/graphics/mac/WebTiledLayer.mm', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp', u'Source/WebCore/platform/graphics/win/FontWin.cpp', u'Source/WebCore/platform/graphics/wince/FontWinCE.cpp', u'Source/WebCore/platform/ios/ContentFilterIOS.mm', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.h', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.mm', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.h', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm', u'Source/WebCore/platform/ios/KeyEventIOS.mm', u'Source/WebCore/platform/ios/MIMETypeRegistryIOS.mm', u'Source/WebCore/platform/ios/MemoryPressureHandlerIOS.mm', u'Source/WebCore/platform/ios/PasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.h', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm', u'Source/WebCore/platform/ios/PlatformPasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformScreenIOS.mm', u'Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm', u'Source/WebCore/platform/ios/SSLKeyGeneratorIOS.cpp', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.h', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.mm', u'Source/WebCore/platform/ios/ScrollViewIOS.mm', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.h', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.mm', u'Source/WebCore/platform/ios/SelectionRect.cpp', u'Source/WebCore/platform/ios/SelectionRect.h', u'Source/WebCore/platform/ios/SoundIOS.mm', u'Source/WebCore/platform/ios/SystemMemoryIOS.cpp', u'Source/WebCore/platform/ios/ThemeIOS.h', u'Source/WebCore/platform/ios/ThemeIOS.mm', u'Source/WebCore/platform/ios/TileCache.h', u'Source/WebCore/platform/ios/TileCache.mm', u'Source/WebCore/platform/ios/TileGrid.h', u'Source/WebCore/platform/ios/TileGrid.mm', u'Source/WebCore/platform/ios/TileGridTile.h', u'Source/WebCore/platform/ios/TileGridTile.mm', u'Source/WebCore/platform/ios/TileLayer.h', u'Source/WebCore/platform/ios/TileLayer.mm', u'Source/WebCore/platform/ios/TileLayerPool.h', u'Source/WebCore/platform/ios/TileLayerPool.mm', u'Source/WebCore/platform/ios/WebCoreMotionManager.h', u'Source/WebCore/platform/ios/WebCoreMotionManager.mm', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.h', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm', u'Source/WebCore/platform/ios/WebEvent.h', u'Source/WebCore/platform/ios/WebEvent.mm', u'Source/WebCore/platform/ios/WidgetIOS.mm', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.h', u'Source/WebCore/platform/mac/FileSystemMac.mm', u'Source/WebCore/platform/mac/KillRingMac.mm', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/mac/PlatformClockCM.mm', u'Source/WebCore/platform/mac/SoftLinking.h', u'Source/WebCore/platform/mac/SystemVersionMac.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.h', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.m', u'Source/WebCore/platform/mac/WebCoreSystemInterface.h', u'Source/WebCore/platform/mac/WebFontCache.mm', u'Source/WebCore/platform/network/BlobRegistry.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/Credential.h', u'Source/WebCore/platform/network/CredentialStorage.cpp', u'Source/WebCore/platform/network/CredentialStorage.h', u'Source/WebCore/platform/network/NetworkStateNotifier.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.h', u'Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp', u'Source/WebCore/platform/network/cf/DNSCFNet.cpp', u'Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequest.h', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp', u'Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.cpp', u'Source/WebCore/platform/network/ios/QuickLook.h', u'Source/WebCore/platform/network/ios/QuickLook.mm', u'Source/WebCore/platform/network/ios/ResourceHandleIOS.mm', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm', u'Source/WebCore/platform/network/mac/AuthenticationMac.mm', u'Source/WebCore/platform/network/mac/CredentialStorageMac.mm', u'Source/WebCore/platform/network/mac/ResourceErrorMac.mm', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/ResourceRequestMac.mm', u'Source/WebCore/platform/network/mac/UTIUtilities.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm', u'Source/WebCore/platform/sql/SQLiteDatabase.h', u'Source/WebCore/platform/sql/SQLiteFileSystem.cpp', u'Source/WebCore/platform/sql/SQLiteFileSystem.h', u'Source/WebCore/platform/sql/SQLiteTransaction.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h', u'Source/WebCore/platform/text/PlatformLocale.cpp', u'Source/WebCore/platform/text/PlatformLocale.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/platform/text/cf/HyphenationCF.cpp', u'Source/WebCore/platform/text/ios/LocalizedDateCache.h', u'Source/WebCore/platform/text/ios/LocalizedDateCache.mm', u'Source/WebCore/platform/text/mac/CharsetData.h', u'Source/WebCore/platform/text/mac/LocaleMac.h', u'Source/WebCore/platform/text/mac/LocaleMac.mm', u'Source/WebCore/platform/text/mac/TextBoundaries.mm', u'Source/WebCore/platform/text/mac/TextCodecMac.cpp', u'Source/WebCore/platform/text/mac/TextCodecMac.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/ios/WebEvent.h:27: #ifndef header guard has wrong style, please use: WebEvent_h [build/header_guard] [5] ERROR: Source/WebCore/platform/ios/WebEvent.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/ScrollAnimatorIOS.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:143: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:250: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:74: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:67: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:71: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1041: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1099: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:52: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:53: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:54: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/mac/SoftLinking.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:122: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:45: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:50: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontPlatformData.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:54: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:55: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:57: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:58: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:59: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:60: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:61: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:62: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:63: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:64: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:65: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:66: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:67: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:68: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 79 in 280 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 8 2014-01-08 13:29:52 PST

Comment on attachment 220656 [details] Patch Attachment 220656 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5071720184545280

Build Bot

Comment 9 2014-01-08 13:46:54 PST

Comment on attachment 220656 [details] Patch Attachment 220656 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6656729009881088

Daniel Bates

Comment 10 2014-01-08 14:55:36 PST

Created attachment 220670 [details] Patch

Daniel Bates

Comment 11 2014-01-08 20:47:55 PST

Created attachment 220696 [details] Patch

WebKit Commit Bot

Comment 12 2014-01-08 20:51:04 PST

Attachment 220696 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/ContentFilter.h', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/FileChooser.cpp', u'Source/WebCore/platform/FileChooser.h', u'Source/WebCore/platform/FileSystem.cpp', u'Source/WebCore/platform/FileSystem.h', u'Source/WebCore/platform/KillRingNone.cpp', u'Source/WebCore/platform/LocalizedStrings.cpp', u'Source/WebCore/platform/LocalizedStrings.h', u'Source/WebCore/platform/Logging.h', u'Source/WebCore/platform/MIMETypeRegistry.cpp', u'Source/WebCore/platform/MemoryPressureHandler.cpp', u'Source/WebCore/platform/MemoryPressureHandler.h', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformScreen.h', u'Source/WebCore/platform/RuntimeApplicationChecks.cpp', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.h', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.mm', u'Source/WebCore/platform/ScrollAnimator.cpp', u'Source/WebCore/platform/ScrollAnimator.h', u'Source/WebCore/platform/ScrollTypes.h', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/platform/ScrollableArea.cpp', u'Source/WebCore/platform/ScrollableArea.h', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/Scrollbar.h', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/SharedBuffer.h', u'Source/WebCore/platform/SuddenTermination.h', u'Source/WebCore/platform/Supplementable.h', u'Source/WebCore/platform/SystemMemory.h', u'Source/WebCore/platform/ThreadCheck.h', u'Source/WebCore/platform/ThreadGlobalData.cpp', u'Source/WebCore/platform/ThreadGlobalData.h', u'Source/WebCore/platform/ThreadTimers.cpp', u'Source/WebCore/platform/Timer.cpp', u'Source/WebCore/platform/Timer.h', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/URL.h', u'Source/WebCore/platform/Widget.h', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.h', u'Source/WebCore/platform/audio/ios/AudioSessionIOS.mm', u'Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp', u'Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp', u'Source/WebCore/platform/audio/mac/AudioSessionMac.cpp', u'Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp', u'Source/WebCore/platform/cf/SharedBufferCF.cpp', u'Source/WebCore/platform/cf/URLCF.cpp', u'Source/WebCore/platform/cocoa/KeyEventCocoa.mm', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/Color.cpp', u'Source/WebCore/platform/graphics/Color.h', u'Source/WebCore/platform/graphics/DisplayRefreshMonitor.h', u'Source/WebCore/platform/graphics/FloatPoint.h', u'Source/WebCore/platform/graphics/FloatRect.h', u'Source/WebCore/platform/graphics/FloatSize.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontPlatformData.cpp', u'Source/WebCore/platform/graphics/FontPlatformData.h', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/Icon.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/IntPoint.h', u'Source/WebCore/platform/graphics/IntRect.h', u'Source/WebCore/platform/graphics/IntSize.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/SimpleFontData.cpp', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/StringTruncator.h', u'Source/WebCore/platform/graphics/TextTrackRepresentation.cpp', u'Source/WebCore/platform/graphics/WidthIterator.h', u'Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAFilters.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp', u'Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ColorCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatPointCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatRectCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/GradientCG.cpp', u'Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCGMac.mm', u'Source/WebCore/platform/graphics/cg/IntPointCG.cpp', u'Source/WebCore/platform/graphics/cg/IntRectCG.cpp', u'Source/WebCore/platform/graphics/cg/IntSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp', u'Source/WebCore/platform/graphics/cg/PathCG.cpp', u'Source/WebCore/platform/graphics/cg/PatternCG.cpp', u'Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm', u'Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm', u'Source/WebCore/platform/graphics/ios/FontCacheIOS.mm', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.h', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.mm', u'Source/WebCore/platform/graphics/ios/GraphicsContext3DIOS.h', u'Source/WebCore/platform/graphics/ios/IconIOS.mm', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.h', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.mm', u'Source/WebCore/platform/graphics/ios/SimpleFontDataIOS.mm', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.h', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm', u'Source/WebCore/platform/graphics/mac/ColorMac.h', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm', u'Source/WebCore/platform/graphics/mac/FloatPointMac.mm', u'Source/WebCore/platform/graphics/mac/FloatRectMac.mm', u'Source/WebCore/platform/graphics/mac/FloatSizeMac.mm', u'Source/WebCore/platform/graphics/mac/FontCacheMac.mm', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp', u'Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp', u'Source/WebCore/platform/graphics/mac/FontMac.mm', u'Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm', u'Source/WebCore/platform/graphics/mac/IconMac.mm', u'Source/WebCore/platform/graphics/mac/ImageMac.mm', u'Source/WebCore/platform/graphics/mac/IntPointMac.mm', u'Source/WebCore/platform/graphics/mac/IntRectMac.mm', u'Source/WebCore/platform/graphics/mac/IntSizeMac.mm', u'Source/WebCore/platform/graphics/mac/MediaPlayerProxy.h', u'Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp', u'Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm', u'Source/WebCore/platform/graphics/mac/WebGLLayer.h', u'Source/WebCore/platform/graphics/mac/WebGLLayer.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebCore/platform/graphics/mac/WebTiledLayer.mm', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp', u'Source/WebCore/platform/graphics/win/FontWin.cpp', u'Source/WebCore/platform/graphics/wince/FontWinCE.cpp', u'Source/WebCore/platform/ios/ContentFilterIOS.mm', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.h', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.mm', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.h', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm', u'Source/WebCore/platform/ios/KeyEventIOS.mm', u'Source/WebCore/platform/ios/MIMETypeRegistryIOS.mm', u'Source/WebCore/platform/ios/MemoryPressureHandlerIOS.mm', u'Source/WebCore/platform/ios/PasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.h', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm', u'Source/WebCore/platform/ios/PlatformPasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformScreenIOS.mm', u'Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm', u'Source/WebCore/platform/ios/SSLKeyGeneratorIOS.cpp', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.h', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.mm', u'Source/WebCore/platform/ios/ScrollViewIOS.mm', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.h', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.mm', u'Source/WebCore/platform/ios/SelectionRect.cpp', u'Source/WebCore/platform/ios/SelectionRect.h', u'Source/WebCore/platform/ios/SoundIOS.mm', u'Source/WebCore/platform/ios/SystemMemoryIOS.cpp', u'Source/WebCore/platform/ios/ThemeIOS.h', u'Source/WebCore/platform/ios/ThemeIOS.mm', u'Source/WebCore/platform/ios/TileCache.h', u'Source/WebCore/platform/ios/TileCache.mm', u'Source/WebCore/platform/ios/TileGrid.h', u'Source/WebCore/platform/ios/TileGrid.mm', u'Source/WebCore/platform/ios/TileGridTile.h', u'Source/WebCore/platform/ios/TileGridTile.mm', u'Source/WebCore/platform/ios/TileLayer.h', u'Source/WebCore/platform/ios/TileLayer.mm', u'Source/WebCore/platform/ios/TileLayerPool.h', u'Source/WebCore/platform/ios/TileLayerPool.mm', u'Source/WebCore/platform/ios/WebCoreMotionManager.h', u'Source/WebCore/platform/ios/WebCoreMotionManager.mm', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.h', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm', u'Source/WebCore/platform/ios/WebEvent.h', u'Source/WebCore/platform/ios/WebEvent.mm', u'Source/WebCore/platform/ios/WidgetIOS.mm', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.h', u'Source/WebCore/platform/mac/FileSystemMac.mm', u'Source/WebCore/platform/mac/KillRingMac.mm', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/mac/PlatformClockCM.mm', u'Source/WebCore/platform/mac/SoftLinking.h', u'Source/WebCore/platform/mac/SystemVersionMac.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.h', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.m', u'Source/WebCore/platform/mac/WebCoreSystemInterface.h', u'Source/WebCore/platform/mac/WebFontCache.mm', u'Source/WebCore/platform/network/BlobRegistry.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/Credential.h', u'Source/WebCore/platform/network/CredentialStorage.cpp', u'Source/WebCore/platform/network/CredentialStorage.h', u'Source/WebCore/platform/network/NetworkStateNotifier.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.h', u'Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp', u'Source/WebCore/platform/network/cf/DNSCFNet.cpp', u'Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequest.h', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp', u'Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.cpp', u'Source/WebCore/platform/network/ios/QuickLook.h', u'Source/WebCore/platform/network/ios/QuickLook.mm', u'Source/WebCore/platform/network/ios/ResourceHandleIOS.mm', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm', u'Source/WebCore/platform/network/mac/AuthenticationMac.mm', u'Source/WebCore/platform/network/mac/CredentialStorageMac.mm', u'Source/WebCore/platform/network/mac/ResourceErrorMac.mm', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/ResourceRequestMac.mm', u'Source/WebCore/platform/network/mac/UTIUtilities.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm', u'Source/WebCore/platform/sql/SQLiteDatabase.h', u'Source/WebCore/platform/sql/SQLiteFileSystem.cpp', u'Source/WebCore/platform/sql/SQLiteFileSystem.h', u'Source/WebCore/platform/sql/SQLiteTransaction.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h', u'Source/WebCore/platform/text/PlatformLocale.cpp', u'Source/WebCore/platform/text/PlatformLocale.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/platform/text/cf/HyphenationCF.cpp', u'Source/WebCore/platform/text/ios/LocalizedDateCache.h', u'Source/WebCore/platform/text/ios/LocalizedDateCache.mm', u'Source/WebCore/platform/text/mac/CharsetData.h', u'Source/WebCore/platform/text/mac/LocaleMac.h', u'Source/WebCore/platform/text/mac/LocaleMac.mm', u'Source/WebCore/platform/text/mac/TextBoundaries.mm', u'Source/WebCore/platform/text/mac/TextCodecMac.cpp', u'Source/WebCore/platform/text/mac/TextCodecMac.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/ios/WebEvent.h:27: #ifndef header guard has wrong style, please use: WebEvent_h [build/header_guard] [5] ERROR: Source/WebCore/platform/ios/WebEvent.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/ScrollAnimatorIOS.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:143: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:250: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:74: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:67: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:71: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1041: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1099: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:52: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:53: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:54: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/mac/SoftLinking.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:122: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:45: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:50: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontPlatformData.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:54: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:55: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:57: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:58: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:59: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:60: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:61: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:62: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:63: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:64: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:65: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:66: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:67: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:68: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 79 in 280 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 13 2014-01-08 21:31:03 PST

Comment on attachment 220696 [details] Patch Attachment 220696 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4676705868316672

Build Bot

Comment 14 2014-01-08 21:50:05 PST

Comment on attachment 220696 [details] Patch Attachment 220696 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6073543318044672

Build Bot

Comment 15 2014-01-08 22:48:06 PST

Comment on attachment 220696 [details] Patch Attachment 220696 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4826516743520256

Daniel Bates

Comment 16 2014-01-09 07:40:01 PST

Created attachment 220733 [details] Patch

WebKit Commit Bot

Comment 17 2014-01-09 07:43:07 PST

Attachment 220733 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/ContentFilter.h', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/FileChooser.cpp', u'Source/WebCore/platform/FileChooser.h', u'Source/WebCore/platform/FileSystem.cpp', u'Source/WebCore/platform/FileSystem.h', u'Source/WebCore/platform/KillRingNone.cpp', u'Source/WebCore/platform/LocalizedStrings.cpp', u'Source/WebCore/platform/LocalizedStrings.h', u'Source/WebCore/platform/Logging.h', u'Source/WebCore/platform/MIMETypeRegistry.cpp', u'Source/WebCore/platform/MemoryPressureHandler.cpp', u'Source/WebCore/platform/MemoryPressureHandler.h', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformScreen.h', u'Source/WebCore/platform/RuntimeApplicationChecks.cpp', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.h', u'Source/WebCore/platform/RuntimeApplicationChecksIOS.mm', u'Source/WebCore/platform/ScrollAnimator.cpp', u'Source/WebCore/platform/ScrollAnimator.h', u'Source/WebCore/platform/ScrollTypes.h', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/platform/ScrollableArea.cpp', u'Source/WebCore/platform/ScrollableArea.h', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/Scrollbar.h', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/SharedBuffer.h', u'Source/WebCore/platform/SuddenTermination.h', u'Source/WebCore/platform/Supplementable.h', u'Source/WebCore/platform/SystemMemory.h', u'Source/WebCore/platform/ThreadCheck.h', u'Source/WebCore/platform/ThreadGlobalData.cpp', u'Source/WebCore/platform/ThreadGlobalData.h', u'Source/WebCore/platform/ThreadTimers.cpp', u'Source/WebCore/platform/Timer.cpp', u'Source/WebCore/platform/Timer.h', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/URL.h', u'Source/WebCore/platform/Widget.h', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioFileReaderIOS.h', u'Source/WebCore/platform/audio/ios/AudioSessionIOS.mm', u'Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp', u'Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp', u'Source/WebCore/platform/audio/mac/AudioSessionMac.cpp', u'Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp', u'Source/WebCore/platform/cf/SharedBufferCF.cpp', u'Source/WebCore/platform/cf/URLCF.cpp', u'Source/WebCore/platform/cocoa/KeyEventCocoa.mm', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/Color.cpp', u'Source/WebCore/platform/graphics/Color.h', u'Source/WebCore/platform/graphics/DisplayRefreshMonitor.h', u'Source/WebCore/platform/graphics/FloatPoint.h', u'Source/WebCore/platform/graphics/FloatRect.h', u'Source/WebCore/platform/graphics/FloatSize.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontPlatformData.cpp', u'Source/WebCore/platform/graphics/FontPlatformData.h', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/Icon.h', u'Source/WebCore/platform/graphics/Image.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/IntPoint.h', u'Source/WebCore/platform/graphics/IntRect.h', u'Source/WebCore/platform/graphics/IntSize.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/SimpleFontData.cpp', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/StringTruncator.h', u'Source/WebCore/platform/graphics/TextTrackRepresentation.cpp', u'Source/WebCore/platform/graphics/WidthIterator.h', u'Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAFilters.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp', u'Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ColorCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatPointCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatRectCG.cpp', u'Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/GradientCG.cpp', u'Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h', u'Source/WebCore/platform/graphics/cg/ImageCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCGMac.mm', u'Source/WebCore/platform/graphics/cg/IntPointCG.cpp', u'Source/WebCore/platform/graphics/cg/IntRectCG.cpp', u'Source/WebCore/platform/graphics/cg/IntSizeCG.cpp', u'Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp', u'Source/WebCore/platform/graphics/cg/PathCG.cpp', u'Source/WebCore/platform/graphics/cg/PatternCG.cpp', u'Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm', u'Source/WebCore/platform/graphics/ios/DisplayRefreshMonitorIOS.mm', u'Source/WebCore/platform/graphics/ios/FontCacheIOS.mm', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.h', u'Source/WebCore/platform/graphics/ios/FontServicesIOS.mm', u'Source/WebCore/platform/graphics/ios/GraphicsContext3DIOS.h', u'Source/WebCore/platform/graphics/ios/IconIOS.mm', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h', u'Source/WebCore/platform/graphics/ios/InbandTextTrackPrivateAVFIOS.mm', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.h', u'Source/WebCore/platform/graphics/ios/MediaPlayerPrivateIOS.mm', u'Source/WebCore/platform/graphics/ios/SimpleFontDataIOS.mm', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.h', u'Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm', u'Source/WebCore/platform/graphics/mac/ColorMac.h', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm', u'Source/WebCore/platform/graphics/mac/FloatPointMac.mm', u'Source/WebCore/platform/graphics/mac/FloatRectMac.mm', u'Source/WebCore/platform/graphics/mac/FloatSizeMac.mm', u'Source/WebCore/platform/graphics/mac/FontCacheMac.mm', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp', u'Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp', u'Source/WebCore/platform/graphics/mac/FontMac.mm', u'Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm', u'Source/WebCore/platform/graphics/mac/IconMac.mm', u'Source/WebCore/platform/graphics/mac/ImageMac.mm', u'Source/WebCore/platform/graphics/mac/IntPointMac.mm', u'Source/WebCore/platform/graphics/mac/IntRectMac.mm', u'Source/WebCore/platform/graphics/mac/IntSizeMac.mm', u'Source/WebCore/platform/graphics/mac/MediaPlayerProxy.h', u'Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp', u'Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm', u'Source/WebCore/platform/graphics/mac/WebGLLayer.h', u'Source/WebCore/platform/graphics/mac/WebGLLayer.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebCore/platform/graphics/mac/WebTiledLayer.mm', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', u'Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp', u'Source/WebCore/platform/graphics/win/FontWin.cpp', u'Source/WebCore/platform/graphics/wince/FontWinCE.cpp', u'Source/WebCore/platform/ios/ContentFilterIOS.mm', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.h', u'Source/WebCore/platform/ios/DeviceMotionClientIOS.mm', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.h', u'Source/WebCore/platform/ios/DeviceOrientationClientIOS.mm', u'Source/WebCore/platform/ios/KeyEventIOS.mm', u'Source/WebCore/platform/ios/MIMETypeRegistryIOS.mm', u'Source/WebCore/platform/ios/MemoryPressureHandlerIOS.mm', u'Source/WebCore/platform/ios/PasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.h', u'Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm', u'Source/WebCore/platform/ios/PlatformPasteboardIOS.mm', u'Source/WebCore/platform/ios/PlatformScreenIOS.mm', u'Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm', u'Source/WebCore/platform/ios/SSLKeyGeneratorIOS.cpp', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.h', u'Source/WebCore/platform/ios/ScrollAnimatorIOS.mm', u'Source/WebCore/platform/ios/ScrollViewIOS.mm', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.h', u'Source/WebCore/platform/ios/ScrollbarThemeIOS.mm', u'Source/WebCore/platform/ios/SelectionRect.cpp', u'Source/WebCore/platform/ios/SelectionRect.h', u'Source/WebCore/platform/ios/SoundIOS.mm', u'Source/WebCore/platform/ios/SystemMemoryIOS.cpp', u'Source/WebCore/platform/ios/ThemeIOS.h', u'Source/WebCore/platform/ios/ThemeIOS.mm', u'Source/WebCore/platform/ios/TileCache.h', u'Source/WebCore/platform/ios/TileCache.mm', u'Source/WebCore/platform/ios/TileGrid.h', u'Source/WebCore/platform/ios/TileGrid.mm', u'Source/WebCore/platform/ios/TileGridTile.h', u'Source/WebCore/platform/ios/TileGridTile.mm', u'Source/WebCore/platform/ios/TileLayer.h', u'Source/WebCore/platform/ios/TileLayer.mm', u'Source/WebCore/platform/ios/TileLayerPool.h', u'Source/WebCore/platform/ios/TileLayerPool.mm', u'Source/WebCore/platform/ios/WebCoreMotionManager.h', u'Source/WebCore/platform/ios/WebCoreMotionManager.mm', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.h', u'Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm', u'Source/WebCore/platform/ios/WebEvent.h', u'Source/WebCore/platform/ios/WebEvent.mm', u'Source/WebCore/platform/ios/WidgetIOS.mm', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.h', u'Source/WebCore/platform/mac/FileSystemMac.mm', u'Source/WebCore/platform/mac/KillRingMac.mm', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/mac/PlatformClockCM.mm', u'Source/WebCore/platform/mac/SoftLinking.h', u'Source/WebCore/platform/mac/SystemVersionMac.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.h', u'Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.h', u'Source/WebCore/platform/mac/WebCoreNSCellExtras.m', u'Source/WebCore/platform/mac/WebCoreSystemInterface.h', u'Source/WebCore/platform/mac/WebFontCache.mm', u'Source/WebCore/platform/network/BlobRegistry.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/Credential.h', u'Source/WebCore/platform/network/CredentialStorage.cpp', u'Source/WebCore/platform/network/CredentialStorage.h', u'Source/WebCore/platform/network/NetworkStateNotifier.h', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.h', u'Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp', u'Source/WebCore/platform/network/cf/DNSCFNet.cpp', u'Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequest.h', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp', u'Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.cpp', u'Source/WebCore/platform/network/ios/QuickLook.h', u'Source/WebCore/platform/network/ios/QuickLook.mm', u'Source/WebCore/platform/network/ios/ResourceHandleIOS.mm', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h', u'Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm', u'Source/WebCore/platform/network/mac/AuthenticationMac.mm', u'Source/WebCore/platform/network/mac/CredentialStorageMac.mm', u'Source/WebCore/platform/network/mac/ResourceErrorMac.mm', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/platform/network/mac/ResourceRequestMac.mm', u'Source/WebCore/platform/network/mac/UTIUtilities.mm', u'Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm', u'Source/WebCore/platform/sql/SQLiteDatabase.h', u'Source/WebCore/platform/sql/SQLiteFileSystem.cpp', u'Source/WebCore/platform/sql/SQLiteFileSystem.h', u'Source/WebCore/platform/sql/SQLiteTransaction.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h', u'Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h', u'Source/WebCore/platform/text/PlatformLocale.cpp', u'Source/WebCore/platform/text/PlatformLocale.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/platform/text/TextEncodingRegistry.cpp', u'Source/WebCore/platform/text/cf/HyphenationCF.cpp', u'Source/WebCore/platform/text/ios/LocalizedDateCache.h', u'Source/WebCore/platform/text/ios/LocalizedDateCache.mm', u'Source/WebCore/platform/text/mac/CharsetData.h', u'Source/WebCore/platform/text/mac/LocaleMac.h', u'Source/WebCore/platform/text/mac/LocaleMac.mm', u'Source/WebCore/platform/text/mac/TextBoundaries.mm', u'Source/WebCore/platform/text/mac/TextCodecMac.cpp', u'Source/WebCore/platform/text/mac/TextCodecMac.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/ios/WebEvent.h:27: #ifndef header guard has wrong style, please use: WebEvent_h [build/header_guard] [5] ERROR: Source/WebCore/platform/ios/WebEvent.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/WebEvent.h:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/ScrollAnimatorIOS.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:143: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:145: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:189: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:190: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp:250: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/BitmapImage.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:74: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:67: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SystemMemoryIOS.cpp:71: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1041: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1099: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:52: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:53: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/text/TextCodecICU.cpp:54: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/mac/SoftLinking.h:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:122: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:45: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:50: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:51: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/graphics/FontPlatformData.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:54: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:55: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:57: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:58: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:59: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:60: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:61: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:62: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:63: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:64: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:65: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:66: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:67: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/ios/SelectionRect.cpp:68: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 79 in 280 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 18 2014-01-09 08:46:01 PST

Comment on attachment 220733 [details] Patch Attachment 220733 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5825924629004288 New failing tests: media/track/media-element-enqueue-event-crash.html

Build Bot

Comment 19 2014-01-09 08:46:05 PST

Created attachment 220742 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

David Kilzer (:ddkilzer)

Comment 20 2014-01-09 14:37:58 PST

Comment on attachment 220733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220733&action=review rs=me. There's no way I could review this whole patch in detail, but I did glance through all of it. > Source/WebCore/platform/ScrollTypes.h:29 > +// WTF_PLATFORM_IOS Nit: This can be removed later. Useless comment at this point. > Source/WebCore/platform/text/TextCodecICU.cpp:197 > + // A.B. adding a few more Mac encodings missing 'cause we don't have TextCodecMac right now A.B. = André Boulé

Daniel Bates

Comment 21 2014-01-09 14:55:23 PST

Committed r161589: <http://trac.webkit.org/changeset/161589>

Daniel Bates

Comment 22 2014-01-09 16:12:17 PST

Committed build fix for Mountain Lion Release (32-bit) in <http://trac.webkit.org/changeset/161592>.

Daniel Bates

Comment 23 2014-01-09 16:18:03 PST

For some reason the Windows build was unhappy with the use of NeverDestroyed<FontCache> in WebCore::FontCache(), as it calls the private constructor FontCache::FontCache(), despite NeverDestroyed<FontCache> being a friend class of FontCache. Committed partial revert in <http://trac.webkit.org/changeset/161598>. For completeness, the standard output for the Apple Win Release bot is at: <http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/56267/steps/compile-webkit/logs/stdio> And here is the relevant error output: 1>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\include\private\wtf/NeverDestroyed.h(52): error C2248: 'WebCore::FontCache::FontCache' : cannot access private member declared in class 'WebCore::FontCache' (..\platform\graphics\FontCache.cpp) c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\graphics\FontCache.h(172) : see declaration of 'WebCore::FontCache::FontCache' c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\graphics\FontCache.h(107) : see declaration of 'WebCore::FontCache' ..\platform\graphics\FontCache.cpp(90) : see reference to function template instantiation 'WTF::NeverDestroyed<WebCore::FontCache>::NeverDestroyed<>(void)' being compiled ..\platform\graphics\FontCache.cpp(90) : see reference to function template instantiation 'WTF::NeverDestroyed<WebCore::FontCache>::NeverDestroyed<>(void)' being compiled

Daniel Bates

Comment 24 2014-01-09 16:40:38 PST

Committed another Windows build fix in <http://trac.webkit.org/changeset/161602>.

Jaehun Lim

Comment 25 2014-01-09 21:07:48 PST

Please fix this failure. EFL debug build has failed. /home/jaehun/source/WebKit/Source/WebCore/platform/ThreadTimers.cpp: In member function ‘void WebCore::ThreadTimers::sharedTimerFiredInternal()’: /home/jaehun/source/WebKit/Source/WebCore/platform/ThreadTimers.cpp:112:56: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 In ThreadTimers.cpp:112, ASSERT(isMainThread() || !isWebThread() && !isUIThread()); We need parentheses. But I don't know where because I'm not familiar to WebThread & UIThread.

Jaehun Lim

Comment 26 2014-01-09 22:11:30 PST

(In reply to comment #25) > Please fix this failure. > > EFL debug build has failed. > > /home/jaehun/source/WebKit/Source/WebCore/platform/ThreadTimers.cpp: In member function ‘void WebCore::ThreadTimers::sharedTimerFiredInternal()’: > /home/jaehun/source/WebKit/Source/WebCore/platform/ThreadTimers.cpp:112:56: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses] > cc1plus: all warnings being treated as errors > make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 > > > In ThreadTimers.cpp:112, > > ASSERT(isMainThread() || !isWebThread() && !isUIThread()); > > We need parentheses. But I don't know where because I'm not familiar to WebThread & UIThread. Fixed in https://bugs.webkit.org/show_bug.cgi?id=126735

Note You need to log in before you can comment on or make changes to this bug.