Bug 126651

Summary:	Subpixel layout: RenderFlexibleBox::alignChildren() needs biased centering.
Product:	WebKit	Reporter:	zalan <zalan>
Component:	Layout and Rendering	Assignee:	zalan <zalan>
Status:	ASSIGNED ---
Severity:	Normal	CC:	jonlee, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	126283

Description zalan 2014-01-08 11:49:16 PST

While adjusting the alignment for children (adjustAlignmentForChild()), we should bias offset the delta when center positioning.
adjustAlignmentForChild(*child, availableAlignmentSpaceForChild(lineCrossAxisExtent, *child) / 2);

failed cases:
fast/forms/range/input-appearance-range.html
fast/hidpi/video-controls-in-hidpi.html
fast/layers/video-layer.html
fast/multicol/client-rects.html

Comment 1 Simon Fraser (smfr) 2014-01-08 15:25:44 PST

Check FF behavior, but prefer subpixel positioning.

Comment 2 Radar WebKit Bug Importer 2014-01-14 10:22:35 PST

<rdar://problem/15815513>

Comment 3 zalan 2014-01-14 16:27:04 PST

These custom controls look different on FF. By looking at the vertical positioning, the old behavior looks more centered. This is similar to bug 101848 (widget content centering)