Bug 126637

Summary:

[GTK][WK2] unskip passing unit tests

Product:

WebKit

Reporter:

Brian Holt <brian.holt>

Component:

WebKitGTK

Assignee:

Brian Holt <brian.holt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Brian Holt

Reported 2014-01-08 06:30:12 PST

$Tools/Scripts/run-gtk-tests --no-xvfb --skipped=ignore Tests failed (2): /WebKit2Gtk/TestInspectorServer, /WebKit2/TestWebKit2 Tests that timed out (1): /WebKit2Gtk/TestWebKitPolicyClient $Tools/Scripts/run-gtk-tests --skipped=ignore Tests failed (4): /WebKit2Gtk/TestWebKitWebView, /WebKit2Gtk/TestWebKitAccessibility, /WebKit2Gtk/TestInspectorServer, /WebKit2/TestWebKit2 Tests that timed out (3): /WebKit2Gtk/TestWebKitPolicyClient, /WebKit2Gtk/TestUIClient, /WebKit2Gtk/TestContextMenu TestResources and TestAuthentication are currently skipped but both pass under xvfb and X.

Attachments
Patch (2.02 KB, patch) 2014-01-08 06:44 PST, Brian Holt	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brian Holt

Comment 1 2014-01-08 06:44:39 PST

Created attachment 220627 [details] Patch

Carlos Garcia Campos

Comment 2 2014-01-08 06:46:58 PST

Comment on attachment 220627 [details] Patch Ok, let's try to unskip them and watch the bots for a while. Thanks.

WebKit Commit Bot

Comment 3 2014-01-08 07:19:43 PST

Comment on attachment 220627 [details] Patch Clearing flags on attachment: 220627 Committed r161499: <http://trac.webkit.org/changeset/161499>

WebKit Commit Bot

Comment 4 2014-01-08 07:19:44 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.