Bug 126636
| Summary: | Enable CSS Feature Queries by default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michał Gołębiowski-Owczarek <m.goleb+bugzilla> |
| Component: | CSS | Assignee: | Benjamin Poulain <benjamin> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | benjamin, vertigoback |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Michał Gołębiowski-Owczarek
Firefox, Chrome & Opera support CSS Feature Queries (i.e. @supports). WebKit should add support as well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Albert Scheiner
It's 'under development' for IE: http://status.modern.ie/conditionalrules?term=@supports
Benjamin Poulain
Weird bug report. WebKit had support for conditional rules for a long time. It is behind the ENABLE_CSS3_CONDITIONAL_RULES flag.
Michał Gołębiowski-Owczarek
OK, this is a request to enable them by default. Just being implemented doesn't really help web developers.
Chrome, Firefox & Opera have it enabled. It's time!
Benjamin Poulain
(In reply to comment #3)
> OK, this is a request to enable them by default. Just being implemented doesn't really help web developers.
>
> Chrome, Firefox & Opera have it enabled. It's time!
Hum? I assume you mean for Safari? The bug tracker for Safari is http://bugreport.apple.com
Michał Gołębiowski-Owczarek
So flags have no defaults? I assumed Safari is mostly compiled with default flag values.
Michał Gołębiowski-Owczarek
I mean, WebKit Nightly has some flags turned on and some not. And some flags must be guarding experimental features so the mere existence of an implementation behind a flag doesn't mean it's finished.
Benjamin Poulain
(In reply to comment #5)
> So flags have no defaults? I assumed Safari is mostly compiled with default flag values.
Safari is definitely not compiled with the default flags.
(In reply to comment #6)
> I mean, WebKit Nightly has some flags turned on and some not. And some flags must be guarding experimental features so the mere existence of an implementation behind a flag doesn't mean it's finished.
WebKit Nightly allows any experimental feature if it has good tests and is relatively stable. Most experimental features are disabled in Safari (thank god :)).
If you want @support to be enabled in WebKit Nightly, that's definitely possible.
Michał Gołębiowski-Owczarek
Thanks for the clarification. :) Should I open a separate bug for that?
Benjamin Poulain
(In reply to comment #8)
> Thanks for the clarification. :) Should I open a separate bug for that?
Let's just repurpose this one.
Benjamin Poulain
I was gonna enable the flag but I see it is already on.
Bear enabled it back in July: https://bugs.webkit.org/show_bug.cgi?id=134404
For Safari itself, you can do two things:
1) File a bug report asking it to be enabled in the next version: http://bugreport.apple.com
2) Write test cases for WebKit.
(1) will basically be like a vote. It is saying that at least one user wants this feature. If there are already existing reports, your "vote" will add up to the original radar by marking it as duplicate.
(2) will help convincing the WebKit community that the feature is ready for prime time. When a feature has outstanding test coverage and there is a strong confidence that it follows the specification, its flag is removed and the feature can no longer be disabled. WebKit has much stronger policies than Mozilla and Google in that respect, we want a lot of good tests.
*** This bug has been marked as a duplicate of bug 134404 ***