Bug 126629

Summary: invalid preprocessing directive in mathtags.in
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cfleizach, commit-queue, dbarton, joepeck, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 100626    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Frédéric Wang (:fredw) 2014-01-08 01:43:14 PST 
WebCore/Modules/mediacontrols/mediaControlsApple.js:825:34: warning: empty character constant [-Winvalid-pp-token]
1 warning generated.
WebCore/mathml/mathtags.in:37:3: error: invalid preprocessing directive
# These presentation MathML elements are not implemented.
  ^
1 error generated.
WebCore/mathml/mathtags.in:37:3: error: invalid preprocessing directive
# These presentation MathML elements are not implemented.

In mathtags.in, # should be replaced with // for comments.
Comment 1 Frédéric Wang (:fredw) 2014-01-08 02:38:57 PST 
Created attachment 220618 [details]
Patch

// does not seem to be accepted outside a # preprocessing instruction, so let's drop these comments.
Comment 2 WebKit Commit Bot 2014-01-08 06:18:12 PST 
Comment on attachment 220618 [details]
Patch

Clearing flags on attachment: 220618

Committed r161495: <http://trac.webkit.org/changeset/161495>
Comment 3 WebKit Commit Bot 2014-01-08 06:18:14 PST 
All reviewed patches have been landed.  Closing bug.