Bug 126609

Summary: [EFL][WK2] Fix failing ewk_view_page_contents_get() API test
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Description Jinwoo Song 2014-01-07 17:28:50 PST 
ewk_view_page_contents_get() API test is failing because of wrong expected result.
Comment 1 Jinwoo Song 2014-01-07 17:34:11 PST 
Created attachment 220573 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-07 17:50:07 PST 
Comment on attachment 220573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220573&action=review

LGTM except for some minor comments.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:217
> +        // Layout tests, so checking the amount of bytes is enough.

Layout -> layout

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:218
> +        Eina_File* pFile = eina_file_open(TEST_RESOURCES_DIR "/resultMHTML.mht", false);

It looks pFile is not EFL or WebKit variable naming style. How about using 'f' or 'file' for it ?
Comment 3 Jinwoo Song 2014-01-07 18:03:20 PST 
Created attachment 220577 [details]
patch for landing
Comment 4 Jinwoo Song 2014-01-07 18:03:43 PST 
Comment on attachment 220573 [details]
Patch

done.
Comment 5 WebKit Commit Bot 2014-01-07 18:38:03 PST 
Comment on attachment 220577 [details]
patch for landing

Clearing flags on attachment: 220577

Committed r161478: <http://trac.webkit.org/changeset/161478>
Comment 6 WebKit Commit Bot 2014-01-07 18:38:06 PST 
All reviewed patches have been landed.  Closing bug.