| Summary: | Move expected results out of messages_unittest.py into separate files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | buildbot, commit-queue, rniwa, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-01-07 14:39:51 PST
Created attachment 220551 [details]
Patch
Attachment 220551 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp', u'Source/WebKit2/Scripts/webkit2/Messages-expected.h', u'Source/WebKit2/Scripts/webkit2/messages_unittest.py', u'Source/WebKit2/Scripts/webkit2/test-messages.in', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/Scripts/webkit2/Messages-expected.h:25: #ifndef header guard has wrong style, please use: Messages_expected_h [build/header_guard] [5]
ERROR: Source/WebKit2/Scripts/webkit2/Messages-expected.h:26: WebPageMessages_h is incorrect. #defined constants should use all uppercase names with words separated by underscores. [readability/naming/define/constants] [4]
ERROR: Source/WebKit2/Scripts/webkit2/Messages-expected.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220551 [details] Patch Attachment 220551 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5667057144168448 Comment on attachment 220551 [details] Patch Attachment 220551 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4946550610460672 |