| Summary: | [GTK][CMake] Links system library to gtkdoc-scan instead of the built one | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||
| Component: | New Bugs | Assignee: | Gustavo Noronha (kov) <gustavo> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | mrobinson | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gustavo Noronha (kov)
2014-01-07 07:27:27 PST
Created attachment 220524 [details]
Patch
Comment on attachment 220524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220524&action=review > Tools/gtk/common.py:48 > + library_build_dir = build_path(*args) What's going on here that it needs the root of the build directory instead of the directory with the libraries? (In reply to comment #2) > > Tools/gtk/common.py:48 > > + library_build_dir = build_path(*args) > > What's going on here that it needs the root of the build directory instead of the directory with the libraries? Exactly! We could land your patch to put the binaries in bin/ and libs in lib/ instead if you prefer, I don't know why they started going to the root, so it may be better to be explicit about it, r=me on it. Thanks. Landed this in: http://trac.webkit.org/changeset/161528. Comment on attachment 220524 [details]
Patch
Thanks!
|