Bug 126582

Summary: [GTK][CMake] Links system library to gtkdoc-scan instead of the built one
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED INVALID    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gustavo Noronha (kov)
Reported 2014-01-07 07:27:27 PST
[GTK][CMake] Links system library to gtkdoc-scan instead of the built one
Attachments
Patch (1.15 KB, patch)
2014-01-07 07:28 PST, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2014-01-07 07:28:54 PST
Created attachment 220524 [details] Patch
Martin Robinson
Comment 2 2014-01-07 08:25:12 PST
Comment on attachment 220524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220524&action=review > Tools/gtk/common.py:48 > + library_build_dir = build_path(*args) What's going on here that it needs the root of the build directory instead of the directory with the libraries?
Gustavo Noronha (kov)
Comment 3 2014-01-08 04:14:54 PST
(In reply to comment #2) > > Tools/gtk/common.py:48 > > + library_build_dir = build_path(*args) > > What's going on here that it needs the root of the build directory instead of the directory with the libraries? Exactly! We could land your patch to put the binaries in bin/ and libs in lib/ instead if you prefer, I don't know why they started going to the root, so it may be better to be explicit about it, r=me on it.
Martin Robinson
Comment 4 2014-01-08 17:16:12 PST
Thanks. Landed this in: http://trac.webkit.org/changeset/161528.
Gustavo Noronha (kov)
Comment 5 2014-01-09 06:07:21 PST
Comment on attachment 220524 [details] Patch Thanks!
Note You need to log in before you can comment on or make changes to this bug.