Bug 126564

Summary: Missleading style error when mixing system and non-system header include lines.
Product: WebKit Reporter: Gergő Balogh <gbalogh.u-szeged>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, galpeter, glenn, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch fix none

Gergő Balogh
Reported 2014-01-07 00:08:34 PST
example: #include "ArgumentEncoder.h" #include "ProcessLauncher.h" #include <QApplication> #include <QLocalServer> #include <QLocalSocket> #include "WebPageProxyMessageKinds.h" #include "WorkItem.h" ERROR: bad.cpp:5: Alphabetical sorting problem. [build/include_order] [4]
Attachments
patch (4.99 KB, patch)
2014-01-07 00:14 PST, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
patch fix (4.67 KB, patch)
2014-01-07 23:59 PST, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gergő Balogh
Comment 1 2014-01-07 00:14:28 PST
Created attachment 220497 [details] patch
Ryosuke Niwa
Comment 2 2014-01-07 02:17:53 PST
Comment on attachment 220497 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=220497&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:2922 > + if previous_line.strip() > line.strip(): We should probably put else here so that we don't end up spitting out two error messages.
Gergő Balogh
Comment 3 2014-01-07 23:59:42 PST
Created attachment 220601 [details] patch fix
WebKit Commit Bot
Comment 4 2014-01-08 18:09:20 PST
Comment on attachment 220601 [details] patch fix Clearing flags on attachment: 220601 Committed r161535: <http://trac.webkit.org/changeset/161535>
WebKit Commit Bot
Comment 5 2014-01-08 18:09:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.