Bug 126559

Summary: [Mac] Be more correct in dealing with NSControlSize
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Mark Rowe (bdash) 2014-01-06 18:44:02 PST 
In several places in WebCore we pass ints or ScrollbarControlSizes in places that NSControlSize is expected. This will break if NSControlSize ever moves from a typedef for NSInteger to an enum.
Comment 1 Mark Rowe (bdash) 2014-01-06 18:46:58 PST 
Created attachment 220481 [details]
Patch
Comment 2 Ryosuke Niwa 2014-01-06 19:34:35 PST 
Comment on attachment 220481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220481&action=review

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:167
> +}

We should have a default value just in case?
Comment 3 Mark Rowe (bdash) 2014-01-06 20:06:32 PST 
Created attachment 220485 [details]
Patch
Comment 4 WebKit Commit Bot 2014-01-06 20:42:02 PST 
Comment on attachment 220485 [details]
Patch

Clearing flags on attachment: 220485

Committed r161397: <http://trac.webkit.org/changeset/161397>
Comment 5 WebKit Commit Bot 2014-01-06 20:42:04 PST 
All reviewed patches have been landed.  Closing bug.