Bug 126539

Summary:

CStack: JSLock drop and grab lock APIs should be private.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, mhahnenberg, msaboff, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	mhahnenberg: review+

Description Mark Lam 2014-01-06 14:08:31 PST

We want the dropping and re-acquisition of the VM API lock to be via the DropAllLocks raii object.  Hence, we should not publicly publishing the APIs for dropping and re-acquiring the locks.

Comment 1 Mark Lam 2014-01-06 14:12:01 PST

Created attachment 220456 [details]
the patch.

Comment 2 Mark Hahnenberg 2014-01-06 14:12:28 PST

Comment on attachment 220456 [details]
the patch.

r=me

Comment 3 Mark Lam 2014-01-06 14:15:06 PST

Thanks for the review.  Landed in r161372 on the jsCStack branch: <http://trac.webkit.org/r161372>.