Bug 126539

Summary: CStack: JSLock drop and grab lock APIs should be private.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. mhahnenberg: review+

Mark Lam
Reported 2014-01-06 14:08:31 PST
We want the dropping and re-acquisition of the VM API lock to be via the DropAllLocks raii object. Hence, we should not publicly publishing the APIs for dropping and re-acquiring the locks.
Attachments
the patch. (1.66 KB, patch)
2014-01-06 14:12 PST, Mark Lam 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-01-06 14:12:01 PST
Created attachment 220456 [details] the patch.
Mark Hahnenberg
Comment 2 2014-01-06 14:12:28 PST
Comment on attachment 220456 [details] the patch. r=me
Mark Lam
Comment 3 2014-01-06 14:15:06 PST
Thanks for the review. Landed in r161372 on the jsCStack branch: <http://trac.webkit.org/r161372>.
Note You need to log in before you can comment on or make changes to this bug.