Bug 126532

Summary: Add new files for UI-side scrolling
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, buildbot, cmarcelo, commit-queue, jamesr, luiz, mkwst, rniwa, sam, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+, buildbot: commit-queue-

Simon Fraser (smfr)
Reported 2014-01-06 12:00:21 PST
Add new files for UI-side scrolling
Attachments
Patch (70.08 KB, patch)
2014-01-06 12:10 PST, Simon Fraser (smfr) 		andersca: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-01-06 12:10:47 PST
Created attachment 220445 [details] Patch
Anders Carlsson
Comment 2 2014-01-06 12:41:11 PST
Comment on attachment 220445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220445&action=review > Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:49 > + explicit RemoteScrollingCoordinatorProxy(WebPageProxy*); Reference? > Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h:41 > + Please get rid of this newline. > Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h:46 > + virtual bool isRemoteScrollingTree() const OVERRIDE { return true; } > + > + virtual EventResult tryToHandleWheelEvent(const WebCore::PlatformWheelEvent&) OVERRIDE; I'd get rid of this newline. > Source/WebKit2/WebProcess/Scrolling/RemoteScrollingCoordinator.h:68 > + // CoreIPC::MessageReceiver Should just be IPC::. > Source/WebKit2/WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in:24 > + ScrollPositionChangedForNode(uint64_t nodeID, WebCore::FloatPoint scrollPosition); Maybe DidChange instead of Changed?
Build Bot
Comment 3 2014-01-06 12:43:18 PST
Comment on attachment 220445 [details] Patch Attachment 220445 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5462873593610240
Build Bot
Comment 4 2014-01-06 13:03:00 PST
Comment on attachment 220445 [details] Patch Attachment 220445 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5147659232870400
Simon Fraser (smfr)
Comment 5 2014-01-06 14:15:59 PST
https://trac.webkit.org/r161373
Note You need to log in before you can comment on or make changes to this bug.