Bug 126528

Summary: [CSS Shapes] shape-outside layout incorrect when line spans rounded box rounded corners
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test case.
none
Test case screenshot.
none
Patch
none
Patch none

Hans Muller
Reported 2014-01-06 10:11:26 PST
Created attachment 220439 [details] Test case. If a line spans a shape-outside box's top/bottom rounded corners, it's starting point is based on (only) the intersection of the top/bottom edges of the line and the corner arcs. The attached example demonstrates the problem.
Attachments
Test case. (972 bytes, text/html)
2014-01-06 10:11 PST, Hans Muller 		no flags
Details
Test case screenshot. (7.15 KB, image/png)
2014-01-06 10:16 PST, Hans Muller 		no flags
Details
Patch (4.17 KB, patch)
2014-01-06 12:05 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
Patch (4.25 KB, patch)
2014-01-06 16:17 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2014-01-06 10:16:35 PST
Created attachment 220440 [details] Test case screenshot.
Hans Muller
Comment 2 2014-01-06 12:05:43 PST
Created attachment 220444 [details] Patch BoxShape::getExcludedIntervals() now checks for the special case where the line spans the top and bottom rounded corners - which implies that the excluded interval is the box's horizontal extent.
Hans Muller
Comment 3 2014-01-06 16:17:04 PST
Created attachment 220467 [details] Patch Corrected the test filenames.
Andreas Kling
Comment 4 2014-01-07 08:03:45 PST
Comment on attachment 220467 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-01-07 10:26:31 PST
Comment on attachment 220467 [details] Patch Clearing flags on attachment: 220467 Committed r161434: <http://trac.webkit.org/changeset/161434>
WebKit Commit Bot
Comment 6 2014-01-07 10:26:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.