| Summary: | [CSS Shapes] shape-outside layout incorrect when line spans rounded box rounded corners | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Muller <giles_joplin> | ||||||||||
| Component: | CSS | Assignee: | Hans Muller <giles_joplin> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 220440 [details]
Test case screenshot.
Created attachment 220444 [details]
Patch
BoxShape::getExcludedIntervals() now checks for the special case where the line spans the top and bottom rounded corners - which implies that the excluded interval is the box's horizontal extent.
Created attachment 220467 [details]
Patch
Corrected the test filenames.
Comment on attachment 220467 [details]
Patch
r=me
Comment on attachment 220467 [details] Patch Clearing flags on attachment: 220467 Committed r161434: <http://trac.webkit.org/changeset/161434> All reviewed patches have been landed. Closing bug. |
Created attachment 220439 [details] Test case. If a line spans a shape-outside box's top/bottom rounded corners, it's starting point is based on (only) the intersection of the top/bottom edges of the line and the corner arcs. The attached example demonstrates the problem.