Bug 126515 – The attribute 'size' of 'select' element doesn't work when size=2 or 3.

• Component: Layout and Rendering
• Status: RESOLVED DUPLICATE

[ChangSeok Oh]

When the size attribute of select tag has 2 or 3. it's working properly. it works like 'size=4'.
Firefox is working with little regard to size=2/3.
As my investigation, this is because minSize in RenderListBox.cpp is limited to 4. 
I can guess there has been a historical reason there with the following comment. but I doubt if it's still valid now.
> // The minSize constant was originally defined to render scrollbars correctly
> // This might vary for different platforms.

I couldn't find any problem for Macport running on Marvericks and Lion. The scrollbar shows up and automatically hide after few seconds on the platforms.
And also I don't think GTK port has any problem for size=2/3, though GTK+ 3.0 doesn't paint scrollbar for such a short list, but it presents more lists remained by using up/down arrow indicators.

I propose to change minSize from 4 to 2.

[ChangSeok Oh]

Created attachment 220420 [details]
Testcase.

[ChangSeok Oh]

Created attachment 220422 [details]
Patch

[Build Bot]

Comment on attachment 220422 [details]
Patch

Attachment 220422 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5269876822245376

New failing tests:
fast/forms/disabled-select-change-index.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/forms/select-clientheight-with-multiple-attr.html
fast/text/international/bidi-listbox.html
fast/replaced/replaced-breaking.html
fast/events/select-element.html

[Build Bot]

Created attachment 220426 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 220422 [details]
Patch

Attachment 220422 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6509237953888256

New failing tests:
fast/forms/disabled-select-change-index.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/forms/select-clientheight-with-multiple-attr.html
fast/text/international/bidi-listbox.html
fast/replaced/replaced-breaking.html
fast/events/select-element.html

[Build Bot]

Created attachment 220428 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 220422 [details]
Patch

Attachment 220422 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5887309777993728

New failing tests:
fast/forms/disabled-select-change-index.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/forms/select-clientheight-with-multiple-attr.html
fast/text/international/bidi-listbox.html
fast/replaced/replaced-breaking.html
fast/events/select-element.html

[Build Bot]

Created attachment 220429 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Alexey Proskuryakov]

*** This bug has been marked as a duplicate of bug 28900 ***

[Alexey Proskuryakov]

Comment on attachment 220422 [details]
Patch

Clearing review flag, please use the original bug.

[ChangSeok Oh]

(In reply to comment #10)
> (From update of attachment 220422 [details])
> Clearing review flag, please use the original bug.

Yeap