Bug 126513

Summary:

RenderBlock::clone() should return RenderPtr.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Andreas Kling 2014-01-06 00:36:12 PST

RenderBlock::clone() should return RenderPtr.

Comment 1 Andreas Kling 2014-01-06 00:40:31 PST

Created attachment 220417 [details]
Patch

Comment 2 Antti Koivisto 2014-01-06 01:13:33 PST

Comment on attachment 220417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220417&action=review

> Source/WebCore/rendering/RenderBlock.cpp:515
> +        RenderPtr<RenderElement> cloneRenderer = element()->createElementRenderer(style());
> +        cloneBlock = RenderPtr<RenderBlock>(toRenderBlock(cloneRenderer.leakPtr()));

:(

Comment 3 Andreas Kling 2014-01-06 02:35:57 PST

Committed r161337: <http://trac.webkit.org/changeset/161337>