Bug 126499

Summary: [Mac] Move WebKit off the legacy WebKit availability macros
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit APIAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126500    
Attachments:
Description Flags
Patch
none
Patch none

Description Mark Rowe (bdash) 2014-01-05 00:29:03 PST 
The legacy WebKit availability macros are verbose, confusing, and provide no benefit over using the system availability macros directly. The original vision was that they'd serve a cross-platform purpose but that never came to be.
Comment 1 Mark Rowe (bdash) 2014-01-05 00:56:48 PST 
Created attachment 220390 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-05 00:58:08 PST 
Attachment 220390 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/objc/WebKitAvailability.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/Carbon/CarbonUtils.h', u'Source/WebKit/mac/Carbon/HIWebView.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/MigrateHeaders.make', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginViewFactory.h', u'Source/WebKit/mac/WebView/WebFrameLoadDelegate.h', u'Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/postprocess-headers.sh', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/bindings/objc/WebKitAvailability.h:26:  #ifndef header guard has wrong style, please use: WebKitAvailability_h  [build/header_guard] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2014-01-05 00:59:43 PST 
Created attachment 220391 [details]
Patch
Comment 4 WebKit Commit Bot 2014-01-05 01:00:48 PST 
Attachment 220391 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/objc/WebKitAvailability.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/Carbon/CarbonUtils.h', u'Source/WebKit/mac/Carbon/HIWebView.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/MigrateHeaders.make', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginViewFactory.h', u'Source/WebKit/mac/WebView/WebFrameLoadDelegate.h', u'Source/WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/postprocess-headers.sh', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/bindings/objc/WebKitAvailability.h:26:  #ifndef header guard has wrong style, please use: WebKitAvailability_h  [build/header_guard] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Mark Rowe (bdash) 2014-01-05 01:05:50 PST 
(In reply to comment #4)
> Attachment 220391 [details] did not pass style-queue:
> 
> ERROR: Source/WebCore/bindings/objc/WebKitAvailability.h:26:  #ifndef header guard has wrong style, please use: WebKitAvailability_h  [build/header_guard] [5]

This is intentional since WebKitAvailability_h is used by JavaScriptCore/WebKitAvailability.h already.
Comment 6 EFL EWS Bot 2014-01-05 02:11:56 PST 
Comment on attachment 220391 [details]
Patch

Attachment 220391 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5176170165305344
Comment 7 Mark Rowe (bdash) 2014-01-05 02:16:29 PST 
(In reply to comment #6)
> (From update of attachment 220391 [details])
> Attachment 220391 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/5176170165305344

This doesn't appear to be related to this patch.
Comment 8 WebKit Commit Bot 2014-01-06 00:12:01 PST 
Comment on attachment 220391 [details]
Patch

Clearing flags on attachment: 220391

Committed r161332: <http://trac.webkit.org/changeset/161332>
Comment 9 WebKit Commit Bot 2014-01-06 00:12:04 PST 
All reviewed patches have been landed.  Closing bug.