Bug 126493 – Prepare the ScrollingTree for remote use

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Prepare the ScrollingTree for remote use

[Simon Fraser (smfr)]

Created attachment 220379 [details]
Patch

[Sam Weinig]

Comment on attachment 220379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220379&action=review

> Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:76
> +        static_cast<GraphicsLayer*>(layer())->syncPosition(position);

Should we have some checked casts for this?

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:79
>      // The cloned tree references PlatformLayers, which are safe to send to the scrolling thread.
>      // FIXME: this Mac threaded-scrolling assumption doesn't belong here.

Does this comment still hold? You removed a similar one above.

> Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp:76
> +        static_cast<GraphicsLayer*>(layer())->syncPosition(position);

Checked cast?

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:201
> +void ScrollingStateTree::setRemovedNodes(const Vector<ScrollingNodeID>& nodes)
> +{
> +    m_nodesRemovedSinceLastCommit = nodes;
> +}

Does this do a copy? Can we make it a move?

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:208
> +    StateNodeMap::const_iterator it = m_stateNodeMap.find(scrollLayerID);

auto?

[EFL EWS Bot]

Comment on attachment 220379 [details]
Patch

Attachment 220379 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5966973905141760

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/161315