| Summary: | Prepare the ScrollingTree for remote use | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-01-04 13:00:45 PST
Created attachment 220379 [details]
Patch
Comment on attachment 220379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220379&action=review > Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:76 > + static_cast<GraphicsLayer*>(layer())->syncPosition(position); Should we have some checked casts for this? > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:79 > // The cloned tree references PlatformLayers, which are safe to send to the scrolling thread. > // FIXME: this Mac threaded-scrolling assumption doesn't belong here. Does this comment still hold? You removed a similar one above. > Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp:76 > + static_cast<GraphicsLayer*>(layer())->syncPosition(position); Checked cast? > Source/WebCore/page/scrolling/ScrollingStateTree.cpp:201 > +void ScrollingStateTree::setRemovedNodes(const Vector<ScrollingNodeID>& nodes) > +{ > + m_nodesRemovedSinceLastCommit = nodes; > +} Does this do a copy? Can we make it a move? > Source/WebCore/page/scrolling/ScrollingStateTree.cpp:208 > + StateNodeMap::const_iterator it = m_stateNodeMap.find(scrollLayerID); auto? Comment on attachment 220379 [details] Patch Attachment 220379 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/5966973905141760 |