Bug 126486

Summary:

CStack Branch: ARM64 add of stack pointer not valid as second source operand

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	mark.lam: review+

Description Michael Saboff 2014-01-03 23:40:26 PST

Due to architectural limitations, the stack pointer register cannot be used as the second source operand for various instructions.  Currently only the add instruction is used by the macro assembler with the stack pointer as the second source operand.  The ARM64 add macro assembler can swap the two source operands in this case.

Comment 1 Michael Saboff 2014-01-03 23:43:59 PST

Created attachment 220368 [details]
Patch

Comment 2 Mark Lam 2014-01-04 07:05:27 PST

Comment on attachment 220368 [details]
Patch

r=me

Comment 3 Michael Saboff 2014-01-04 10:28:14 PST

Committed r161313: <http://trac.webkit.org/changeset/161313>