Bug 126465

Summary: [GTK] [CMake] Parallel builds still fail when building WebKit2 GObject API unit tests
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix bug description none

Martin Robinson
Reported 2014-01-03 15:05:38 PST
We need to make more changes imilar to http://trac.webkit.org/changeset/161145/trunk/Source/WebKit2/UIProcess/API/gtk/tests/CMakeLists.txt to ensure that parallel builds work properly.
Attachments
Patch (1.82 KB, patch)
2014-01-03 15:07 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Fix bug description (1.82 KB, patch)
2014-01-03 15:12 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-01-03 15:07:34 PST
Created attachment 220343 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-03 15:10:26 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2014-01-03 15:12:20 PST
Created attachment 220344 [details] Fix bug description
Martin Robinson
Comment 4 2014-01-06 10:57:37 PST
Comment on attachment 220344 [details] Fix bug description Clearing flags on attachment: 220344 Committed r161354: <http://trac.webkit.org/changeset/161354>
Martin Robinson
Comment 5 2014-01-06 10:57:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.