Summary: | [iOS] [WK2] TileController creates all tiles on first paint, making it slow and consuming lots of memory | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, benjamin, matthew_hanson, sam, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-01-03 13:41:34 PST
Created attachment 220335 [details]
patch
Created attachment 220336 [details]
fix the title for sam
Comment on attachment 220336 [details] fix the title for sam View in context: https://bugs.webkit.org/attachment.cgi?id=220336&action=review > Source/WebKit2/ChangeLog:24 > + We can't use the existing WKContentView didScrollTo:, because it is > + expected to only fire when a scroll lands. Instead, add didLiveScrollTo:, > + which fires continually as scrolling progresses. Naming proposal: rename didScrollTo: to didFinishScrollTo:, and use didScrollTo: instead of didLiveScrollTo: Comment on attachment 220336 [details] fix the title for sam View in context: https://bugs.webkit.org/attachment.cgi?id=220336&action=review > Source/WebKit2/UIProcess/API/ios/WKContentView.h:68 > +- (void)didLiveScrollTo:(CGPoint)contentOffset; Hmm, we don't really use the term "live scroll" anywhere else. > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:141 > + _page->viewExposedRectChanged(FloatRect(_page->viewExposedRect().location(), FloatSize(size)), true); No idea what true means. > Source/WebKit2/UIProcess/WebPageProxy.cpp:4398 > +void WebPageProxy::viewExposedRectChanged(const FloatRect& exposedRect, bool clipsToExposedRect) Please replace clipsToExposedRect with an enum |